Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 445983002: Update gcmole to a more recent clang/llvm. (Closed)

Created:
6 years, 4 months ago by Sven Panne
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Update gcmole to a more recent clang/llvm. * Changes for 2.9: * Use CXX in Makefile instead of hardwired g++, we need a more modern GCC than 4.6 later, anyway. * Changes for 3.0: * Use llvm namespace. * Diagnostic => DiagnosticsEngine. * Changes for 3.1: * The BlockDeclRefExpr AST node is gone. * The structure of the CXXNewExpr AST node has changed. * Path changed from Release to Release+Asserts. * Use clang++ instead of -cc1, otherwise we lose the system include paths. * Changes for 3.2: none needed * Changes for 3.3: * Use lookup_iterator::begin/end instead of first/second. * Changes for 3.4: * createItaniumMangleContext => ItaniumMangleContext::create. * Changes for 3.5: * clang uses <type_traits> now, so -std=c++0x is needed. * Type-trait-related AST changes. * getCustomDiagID signature changed. * We must link the C++ library statically now. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22972

Patch Set 1 : #

Patch Set 2 : Changes up to 3.5 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -90 lines) Patch
M .gitignore View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/gcmole/Makefile View 1 1 chunk +7 lines, -8 lines 0 comments Download
M tools/gcmole/bootstrap.sh View 1 3 chunks +7 lines, -4 lines 0 comments Download
M tools/gcmole/gcmole.cc View 1 25 chunks +53 lines, -74 lines 0 comments Download
M tools/gcmole/gcmole.lua View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Sven Panne
work in progress, just for entertainment... ;-)
6 years, 4 months ago (2014-08-06 13:51:54 UTC) #1
Michael Starzinger
LGTM. But if we land this now I assume it will fail on the GCMole ...
6 years, 4 months ago (2014-08-06 13:57:31 UTC) #2
Sven Panne
6 years, 4 months ago (2014-08-07 06:28:51 UTC) #3
Sven Panne
[ I've put the other Michael onto this, too, confusing... ;-] As Michi already mentioned, ...
6 years, 4 months ago (2014-08-07 06:38:16 UTC) #4
Michael Starzinger
IMHO making the bots use their own copy of gcmole.lua would be a step backwards. ...
6 years, 4 months ago (2014-08-07 08:05:16 UTC) #5
Michael Starzinger
As per offline investigation: The new Lua script in this CL still works with the ...
6 years, 4 months ago (2014-08-07 08:42:27 UTC) #6
Sven Panne
CL finished: gcmole is based on clang 3.5 now. I think we can land this ...
6 years, 4 months ago (2014-08-07 11:51:29 UTC) #7
Michael Starzinger
Still LGTM.
6 years, 4 months ago (2014-08-07 12:49:44 UTC) #8
Sven Panne
6 years, 4 months ago (2014-08-07 12:57:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as 22972 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698