Issue 445953002: Fix how --gtest_filter interacts with PRE_ tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 445953002: Fix how --gtest_filter interacts with PRE_ tests (Closed)

Created:
6 years, 4 months ago by Paweł Hajdan Jr.

Modified:
6 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	base/test/launcher/test_launcher.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

sky

LGTM - it would be nice to have test coverage of the test launcher

6 years, 4 months ago (2014-08-06 17:54:45 UTC) #2

Paweł Hajdan Jr.

6 years, 4 months ago (2014-08-08 10:09:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 288298 (presubmit successful).