Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: src/ic.h

Issue 445943002: CallIC must update type feedback info correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ic.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic.h
diff --git a/src/ic.h b/src/ic.h
index 606da14b8d6abff45ad908faeb18c902f1be75e9..72cc3f62c6b9248800a51cf5d3f0de17d4a45af9 100644
--- a/src/ic.h
+++ b/src/ic.h
@@ -175,6 +175,9 @@ class IC {
static inline void SetTargetAtAddress(Address address,
Code* target,
ConstantPoolArray* constant_pool);
+ static void OnTypeFeedbackChanged(Isolate* isolate, Address address,
+ State old_state, State new_state,
+ bool target_remains_ic_stub);
static void PostPatching(Address address, Code* target, Code* old_target);
// Compute the handler either by compiling or by retrieving a cached version.
@@ -377,6 +380,10 @@ class CallIC: public IC {
static void Clear(Isolate* isolate, Address address, Code* target,
ConstantPoolArray* constant_pool);
+
+ private:
+ void UpdateTypeFeedbackInfo(Object* old_feedback, Object* new_feedback);
+ inline IC::State FeedbackObjectToState(Object* feedback) const;
};
« no previous file with comments | « no previous file | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698