CallIC must update type feedback info correctly.

src/ia32/code-stubs-ia32.cc

Index: src/ia32/code-stubs-ia32.cc
diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc
index 104576e64a949d896ac05c638d0ab1945669c506..6edb243de1ec183d1ef48e4e600af036c2a3ff40 100644
--- a/src/ia32/code-stubs-ia32.cc
+++ b/src/ia32/code-stubs-ia32.cc
@@ -2455,18 +2455,6 @@ void CallICStub::Generate(MacroAssembler* masm) {
   __ cmp(ecx, Immediate(TypeFeedbackInfo::UninitializedSentinel(isolate)));
   __ j(equal, &miss);
 
-  if (!FLAG_trace_ic) {
-    // We are going megamorphic. If the feedback is a JSFunction, it is fine

[Jakob Kummerow, 2014/08/06 14:49:09]

Removing optimizations is sad... is the type feedback vector for calls shared
with optimized code (when it's megamorphic)? Maybe we can just keep this code --
even though it violates consistency of overall system behavior, maybe it's an
exception to the rule that we can afford not to care about.

[mvstanton, 2014/08/06 15:32:33]

That sounds good to me. I'll move this change to a separate CL which I'll test
against benchmarks.

-    // to handle it here. More complex cases are dealt with in the runtime.
-    __ AssertNotSmi(ecx);
-    __ CmpObjectType(ecx, JS_FUNCTION_TYPE, ecx);
-    __ j(not_equal, &miss);
-    __ mov(FieldOperand(ebx, edx, times_half_pointer_size,
-                        FixedArray::kHeaderSize),
-           Immediate(TypeFeedbackInfo::MegamorphicSentinel(isolate)));
-    __ jmp(&slow_start);
-  }
-
   // We are here because tracing is on or we are going monomorphic.
   __ bind(&miss);
   GenerateMiss(masm, IC::kCallIC_Miss);