Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 445933006: Files.app: Enable unintentionally-disabled browser tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
diff --git a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
index 1e33eb82fdd14381802459079dc2d72382901e4c..433d78fcceb211047be80d6ca4d0a243d69fe986 100644
--- a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
+++ b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
@@ -747,8 +747,7 @@ class FileManagerBrowserTest :
}
};
-// http://crbug.com/400892
-IN_PROC_BROWSER_TEST_P(FileManagerBrowserTest, DISABLED_Test) {
+IN_PROC_BROWSER_TEST_P(FileManagerBrowserTest, Test) {
StartTest();
}
@@ -784,27 +783,17 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
TestParameter(NOT_IN_GUEST_MODE, "zipOpenDownloads"),
TestParameter(NOT_IN_GUEST_MODE, "zipOpenDrive")));
-// Slow tests are disabled on debug build. http://crbug.com/327719
-#if !defined(NDEBUG)
-#define MAYBE_OpenVideoFiles DISABLED_OpenVideoFiles
-#else
-#define MAYBE_OpenVideoFiles OpenVideoFiles
-#endif
+// http://crbug.com/400892
WRAPPED_INSTANTIATE_TEST_CASE_P(
- MAYBE_OpenVideoFiles,
+ DISABLED_OpenVideoFiles,
FileManagerBrowserTest,
::testing::Values(TestParameter(IN_GUEST_MODE, "videoOpenDownloads"),
TestParameter(NOT_IN_GUEST_MODE, "videoOpenDownloads"),
TestParameter(NOT_IN_GUEST_MODE, "videoOpenDrive")));
-// Slow tests are disabled on debug build. http://crbug.com/327719
-#if !defined(NDEBUG)
-#define MAYBE_OpenAudioFiles DISABLED_OpenAudioFiles
-#else
-#define MAYBE_OpenAudioFiles OpenAudioFiles
-#endif
+// http://crbug.com/401674
WRAPPED_INSTANTIATE_TEST_CASE_P(
- MAYBE_OpenAudioFiles,
+ DISABLED_OpenAudioFiles,
FileManagerBrowserTest,
::testing::Values(
TestParameter(IN_GUEST_MODE, "audioOpenDownloads"),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698