Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issue 445933006: Files.app: Enable unintentionally-disabled browser tests. (Closed)

Created:
6 years, 4 months ago by fukino
Modified:
6 years, 4 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Files.app: Enable unintentionally-disabled browser tests. All browser tests of File.app were disabled unintentionally by crrev.com/444223003 This CL enables those tests and disables OpenVideoFile and OpenAudioFile individually. BUG=400892 TEST=run browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -16 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 2 chunks +5 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
fukino
@yoshiki, PTAL the CL? Thanks!
6 years, 4 months ago (2014-08-07 20:31:39 UTC) #1
yoshiki
lgtm sorry. you can use TBR to commit a CL like this.
6 years, 4 months ago (2014-08-08 04:55:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/445933006/1
6 years, 4 months ago (2014-08-08 04:56:34 UTC) #3
fukino
On 2014/08/08 04:56:34, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 4 months ago (2014-08-08 05:12:39 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-08 06:24:50 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 10:38:20 UTC) #6
Message was sent while issue was closed.
Change committed as 288316

Powered by Google App Engine
This is Rietveld 408576698