Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: content/browser/service_worker/service_worker_provider_host.h

Issue 445883003: ServiceWorker: Consolidate version change messages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_provider_host.h
diff --git a/content/browser/service_worker/service_worker_provider_host.h b/content/browser/service_worker/service_worker_provider_host.h
index 32504c3f67b8ffa9fde7c0b99fad31f3449251ff..bd0d9e96778b5957ab62237dfec38d399e49dd35 100644
--- a/content/browser/service_worker/service_worker_provider_host.h
+++ b/content/browser/service_worker/service_worker_provider_host.h
@@ -78,10 +78,6 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
void SetDocumentUrl(const GURL& url);
const GURL& document_url() const { return document_url_; }
- // Associates |version| to the controller field or if |version| is NULL clears
- // the field.
- void SetControllerVersion(ServiceWorkerVersion* version);
-
// Associates to |registration| to listen for its version change events.
void AssociateRegistration(ServiceWorkerRegistration* registration);
@@ -98,9 +94,6 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
ResourceType resource_type,
base::WeakPtr<webkit_blob::BlobStorageContext> blob_storage_context);
- // Returns true if |version| can be associated with this provider.
- bool CanAssociateVersion(ServiceWorkerVersion* version);
-
// Returns true if |registration| can be associated with this provider.
bool CanAssociateRegistration(ServiceWorkerRegistration* registration);
@@ -123,15 +116,22 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
virtual void OnRegistrationFailed(
ServiceWorkerRegistration* registration) OVERRIDE;
- // Associates |version| to the corresponding field or if |version| is NULL
+ // Sets the corresponding version field to the given version or if the given
+ // version is NULL, clears the field.
+ void SetVersionAttributes(
+ ServiceWorkerVersion* installing_version,
+ ServiceWorkerVersion* waiting_version,
+ ServiceWorkerVersion* active_version);
+ void SetVersionAttributesInternal(
+ ServiceWorkerVersion* version,
+ scoped_refptr<ServiceWorkerVersion>* data_member);
+
+ // Sets the controller version field to |version| or if |version| is NULL,
// clears the field.
- void SetActiveVersion(ServiceWorkerVersion* version);
- void SetWaitingVersion(ServiceWorkerVersion* version);
- void SetInstallingVersion(ServiceWorkerVersion* version);
+ void SetControllerVersionAttribute(ServiceWorkerVersion* version);
- // If |version| is the installing, waiting, or active version of this
- // provider, the method will reset that field to NULL.
- void UnsetVersion(ServiceWorkerVersion* version);
+ // Clears all version fields.
+ void ClearVersionAttributes();
// Creates a ServiceWorkerHandle to retain |version| and returns a
// ServiceWorkerInfo with the handle ID to pass to the provider. The

Powered by Google App Engine
This is Rietveld 408576698