Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 445883002: Support <input webkitdirectory> in KDE file chooser (Closed)

Created:
6 years, 4 months ago by robwu
Modified:
6 years, 4 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, lazyboy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support <input webkitdirectory> in KDE file chooser Currently NOTREACHED() is reached when the KDE file chooser is active. TEST=Manually: 1. Start Chrome in a KDE environment 2. Visit data:text/html,<input type=file webkitdirectory> 3. Click on the file chooser and select any directory. 4. In KDE environments, NOTREACHED() is reached. 5. Repeat the same steps with the env var NO_CHROME_KDE_FILE_DIALOG=1, and observe that NOTREACHED() is not reached any more, because the gtk fallback is used (which works correctly since r240564). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
robwu
6 years, 4 months ago (2014-08-06 08:39:04 UTC) #1
Elliot Glaysher
lgtm
6 years, 4 months ago (2014-08-06 20:01:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob@robwu.nl/445883002/1
6 years, 4 months ago (2014-08-06 20:04:06 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 21:33:29 UTC) #4
Message was sent while issue was closed.
Change committed as 287863

Powered by Google App Engine
This is Rietveld 408576698