Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 445793004: Fix import order with isort tool. (Closed)

Created:
6 years, 4 months ago by nednguyen
Modified:
6 years, 4 months ago
Reviewers:
tonyg, chrishenry
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix import order with isort tool. https://github.com/timothycrosley/isort I ran isort -sl on files that does not contain util.AddDirToPythonPath. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289043

Patch Set 1 : #

Total comments: 19

Patch Set 2 : Address Chris' comments #

Total comments: 1

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -137 lines) Patch
M tools/telemetry/telemetry/benchmark.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/browser_backend.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_with_oobe.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_interface_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_console.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_console_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_memory.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_page.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_runtime.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder_unittest.py View 2 chunks +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/oobe.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/websocket_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/facebook_credentials_backend.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/facebook_credentials_backend_unittest.py View 1 chunk +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/google_credentials_backend.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/google_credentials_backend_unittest.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/webdriver/webdriver_ie_backend.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_list_backend.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/bitmap_unittest.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/browser.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_credentials.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/browser_credentials_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_finder.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/browser_options_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/discover_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/extension_to_load.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/gpu_device_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/gpu_info.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/gpu_info_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/heap/chrome_js_heap_snapshot_parser.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/heap/chrome_js_heap_snapshot_parser_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/heap/model.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/local_server.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/local_server_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/memory_cache_http_server.py View 2 chunks +1 line, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/mac_platform_backend.py View 1 chunk +6 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py View 1 1 chunk +3 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor.py View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/power_monitor_controller_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/proc_supporting_platform_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_screen_recorder_profiler.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/netlog_profiler.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/v8_profiler.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/vtune_profiler_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/win_pgo_profiler.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/win_platform_backend.py View 2 chunks +7 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/profile_types.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/system_info.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/system_info_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/tab_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/util_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/webpagereplay.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/wpr_modes.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/wpr_server.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/javascript_click.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/loop_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/page_action.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/pinch.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/play_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/repaint_continuously.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/scroll.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/scroll_bounce.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/seek_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/swipe.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/tap.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/wait.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner_unittest.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_set.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_set_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/profile_creator.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/profile_generator_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/base_test_results_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/buildbot_output_formatter.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/csv_output_formatter_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/results/json_output_formatter.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/results/json_output_formatter_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/results/page_test_results_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/results_options.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/test_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/testing/page_test_test_case.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/timeline/async_slice.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/timeline/counter.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/timeline/empty_timeline_data_importer.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/timeline/event_container.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/timeline/flow_event.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/timeline/inspector_importer.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/timeline/inspector_importer_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/timeline/inspector_timeline_data.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/timeline/model.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/timeline/model_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/timeline/process.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/timeline/sample.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/timeline/slice.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/timeline/slice_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/timeline/thread.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/timeline/thread_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/timeline/trace_event_importer.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/timeline/trace_event_importer_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/timeline/tracing_timeline_data.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/unittest/decorators_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/unittest/gtest_progress_reporter_unittest.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/unittest/simple_mock_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/unittest/test.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/util/cloud_storage.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/util/find_dependencies.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/util/statistics_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/util/support_binaries_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/failure.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/failure_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/value/histogram.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/histogram_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/list_of_scalar_values.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/list_of_scalar_values_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/list_of_string_values.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/list_of_string_values_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/merge_values.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/merge_values_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/scalar.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/scalar_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/skip.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/skip_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/string.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/string_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/summary.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/value_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/web_components/dev_server.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_components/web_component_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/web_components/web_components_project.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/fast_metric_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/rendering_frame.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/rendering_frame_unittest.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/rendering_stats.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/smoothness.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement.py View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_interaction_record.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/unittest_data/test_page_set.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/unittest_data/test_simple_one_page_set.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/unittest_data/test_simple_two_page_set.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nednguyen
6 years, 4 months ago (2014-08-07 21:29:18 UTC) #1
chrishenry
lgtm I might miss other sort order mistake, but the tool doesn't seem to do ...
6 years, 4 months ago (2014-08-07 23:13:38 UTC) #2
nednguyen
https://codereview.chromium.org/445793004/diff/40001/tools/telemetry/examples/telemetry_perf_test.py File tools/telemetry/examples/telemetry_perf_test.py (right): https://codereview.chromium.org/445793004/diff/40001/tools/telemetry/examples/telemetry_perf_test.py#newcode13 tools/telemetry/examples/telemetry_perf_test.py:13: sys.path.append(os.path.join(os.path.dirname(__file__), os.pardir)) On 2014/08/07 23:13:37, chrishenry wrote: > What ...
6 years, 4 months ago (2014-08-08 01:13:27 UTC) #3
tonyg
lgtm /me wonders whether we should run this as part of the PRESUBMIT https://codereview.chromium.org/445793004/diff/60001/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py File ...
6 years, 4 months ago (2014-08-09 18:14:04 UTC) #4
nednguyen
On 2014/08/09 18:14:04, tonyg wrote: > lgtm > > /me wonders whether we should run ...
6 years, 4 months ago (2014-08-10 05:44:06 UTC) #5
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 4 months ago (2014-08-12 15:40:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/445793004/80001
6 years, 4 months ago (2014-08-12 15:43:05 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 19:07:02 UTC) #8
Message was sent while issue was closed. 
Change committed as 289043

Powered by Google App Engine
This is Rietveld 408576698