Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 445793003: Add permission check to FakeDriveService (Closed)

Created:
6 years, 4 months ago by hashimoto
Modified:
6 years, 4 months ago
Reviewers:
kinaba
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add permission check to FakeDriveService Add a new method SetUserPermission() to set the user's permission for a file. Check the permission in DeleteResource(), TrashResource(), UpdateResource() and InitiateUploadExistingFile(). This change doesn't cover: - Permission check for the parent when adding/removing entries to a directory. - Cases where the permission is changed while upload is in progress. (even not sure what happens in the production) BUG=340933 TEST=unit_tests --gtest_filter="FakeDriveServiceTest.*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288062

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -0 lines) Patch
M chrome/browser/drive/fake_drive_service.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 1 7 chunks +56 lines, -0 lines 0 comments Download
M chrome/browser/drive/fake_drive_service_unittest.cc View 1 5 chunks +72 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
hashimoto
6 years, 4 months ago (2014-08-07 05:54:16 UTC) #1
kinaba
lgtm
6 years, 4 months ago (2014-08-07 08:41:01 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-07 10:16:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/445793003/40001
6 years, 4 months ago (2014-08-07 10:17:32 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-07 10:21:31 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 10:23:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/2333) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/710)
6 years, 4 months ago (2014-08-07 10:23:10 UTC) #7
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-07 10:26:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/445793003/60001
6 years, 4 months ago (2014-08-07 10:28:06 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-07 13:25:53 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 16:03:47 UTC) #11
Message was sent while issue was closed.
Change committed as 288062

Powered by Google App Engine
This is Rietveld 408576698