make rebaseline_server properly handle unescaped URLs

make rebaseline_server properly handle unescaped URLs

TBR=rmistry
NOTREECHECKS=true
NOTRY=true

Committed: https://skia.googlesource.com/skia/+/c8d8a604bf995856d3f147dc3a1b010d8e4efa06

[epoger, 2014-08-07 21:36:22]

This should fix an annoying problem that only appeared in production, when the
rebaseline_server is called by way of the redirect URL.  (But it was an actual
bug in rebaseline_server, so good to fix it.)


For example, in
http://108.170.220.120:10117/builders/Test-Mac10.8-MacMini4.1-GeForce320M-x86...
:

Triggering prefetch URL
http://skia-tree-status.appspot.com/redirect/rebaseline-server/prefetch/setAD...


When this request was forwarded to the rebaseline server by
skia-tree-status.appspot.com/redirect , the escaped slashes (%2F) were converted
to plain slashes... and the rebaseline server converted "gs://bucket" to
"gs:/bucket" in the normpath call.


That resulted in errors like this on the server side:

107.178.200.203 - - [07/Aug/2014 19:45:13] "GET / HTTP/1.1" 301 -
216.239.33.117 - - [07/Aug/2014 19:45:33] code 404, message Not Found
216.239.33.117 - - [07/Aug/2014 19:45:33] "GET
/prefetch/setADir=gs://chromium-skia-skp-summaries/Test-Ubuntu12-ShuttleA-GTX660-x86-Release&setBDir=gs://chromium-skia-skp-summaries/Test-Ubuntu12-ShuttleA-GTX660-x86-Release&setASection=expected-results&setBSection=actual-results
HTTP/1.1" 404 -
Traceback (most recent call last):
  File "/usr/lib/python2.7/SocketServer.py", line 295, in
_handle_request_noblock
    self.process_request(request, client_address)
  File "/usr/lib/python2.7/SocketServer.py", line 321, in process_request
    self.finish_request(request, client_address)
  File "/usr/lib/python2.7/SocketServer.py", line 334, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/lib/python2.7/SocketServer.py", line 649, in __init__
    self.handle()
  File "/usr/lib/python2.7/BaseHTTPServer.py", line 340, in handle
    self.handle_one_request()
  File "/usr/lib/python2.7/BaseHTTPServer.py", line 328, in handle_one_request
    method()
  File "/home/default/rebaseline_server/skia/gm/rebaseline_server/server.py",
line 487, in do_GET
    dispatcher(remainder)
  File "/home/default/rebaseline_server/skia/gm/rebaseline_server/server.py",
line 550, in do_GET_prefetch_results
    param_dict=param_dict, prefetch_only=True)
  File "/home/default/rebaseline_server/skia/gm/rebaseline_server/server.py",
line 722, in _call_compare_rendered_pictures
    prefetch_only=prefetch_only, download_all_images=download_all_images)
  File
"/home/default/rebaseline_server/skia/gm/rebaseline_server/compare_rendered_pictures.py",
line 142, in __init__
    self._copy_dir_contents(source_dir=source_dir, dest_dir=setA_root)
  File
"/home/default/rebaseline_server/skia/gm/rebaseline_server/compare_rendered_pictures.py",
line 386, in _copy_dir_contents
    shutil.copytree(source_dir, dest_dir)
  File "/usr/lib/python2.7/shutil.py", line 171, in copytree
    names = os.listdir(src)
OSError: [Errno 2] No such file or directory:
'gs:/chromium-skia-skp-summaries/Test-Ubuntu12-ShuttleA-GTX660-x86-Release'

[epoger, 2014-08-07 21:37:21]

committing TBR

[epoger, 2014-08-07 21:37:25]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-08-07 21:38:17]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/epoger@google.com/445753005/1

[commit-bot: I haz the power, 2014-08-07 21:39:29]

Change committed as c8d8a604bf995856d3f147dc3a1b010d8e4efa06