[Suggestions] Rename ThumbnailManager to ImageManagerImpl

[Suggestions] Rename ThumbnailManager to ImageManagerImpl

For future use with favicons, remove reference to "thumbnail". There is no functionality change in this CL, just a rename.

BUG=388747
TEST=ImageManager*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288260

[Mathieu, 2014-08-07 19:01:33]

Have a look!

[huangs, 2014-08-07 20:33:33]

LGTM with nits.

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
File chrome/browser/search/suggestions/image_manager_impl.cc (right):

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
chrome/browser/search/suggestions/image_manager_impl.cc:127: ImageMap::iterator
thumb_iter = image_map_.find(url.spec());
NIT: rename |thumb_iter|.

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
chrome/browser/search/suggestions/image_manager_impl.cc:161:
ImageRequestMap::iterator thumb_iter =
NIT: rename |thumb_iter|.

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
chrome/browser/search/suggestions/image_manager_impl.cc:242: void
ImageManagerImpl::LoadEntriesInCache(
Unwrap.

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
File chrome/browser/search/suggestions/image_manager_impl.h (right):

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
chrome/browser/search/suggestions/image_manager_impl.h:31: class ImageData;
Sort alphabetically??

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
chrome/browser/search/suggestions/image_manager_impl.h:140: std::vector<unsigned
char>* dest);
Fix indent.

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
File chrome/browser/search/suggestions/image_manager_impl_browsertest.cc
(right):

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
chrome/browser/search/suggestions/image_manager_impl_browsertest.cc:138:
/*std::vector<unsigned char> actual;
Note comment block?

https://codereview.chromium.org/445753004/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/445753004/diff/1/chrome/chrome_browser.gypi#n...
chrome/chrome_browser.gypi:1140:
'browser/search/suggestions/image_manager_impl.cc',
Sort alphabetically.

https://codereview.chromium.org/445753004/diff/1/components/suggestions/proto...
File components/suggestions/proto/suggestions.proto (right):

https://codereview.chromium.org/445753004/diff/1/components/suggestions/proto...
components/suggestions/proto/suggestions.proto:55: // ImageData contains the
data to represent a website image (thumbnail,
Note that favicon are not JPEG in general, so more work will be needed.

[Mathieu, 2014-08-07 21:03:35]

Should be all good now. Submitting.

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
File chrome/browser/search/suggestions/image_manager_impl.cc (right):

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
chrome/browser/search/suggestions/image_manager_impl.cc:127: ImageMap::iterator
thumb_iter = image_map_.find(url.spec());
On 2014/08/07 20:33:32, huangs1 wrote:
> NIT: rename |thumb_iter|.

Done.

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
chrome/browser/search/suggestions/image_manager_impl.cc:161:
ImageRequestMap::iterator thumb_iter =
On 2014/08/07 20:33:32, huangs1 wrote:
> NIT: rename |thumb_iter|.

Done.

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
chrome/browser/search/suggestions/image_manager_impl.cc:242: void
ImageManagerImpl::LoadEntriesInCache(
On 2014/08/07 20:33:32, huangs1 wrote:
> Unwrap.

Done.

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
File chrome/browser/search/suggestions/image_manager_impl.h (right):

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
chrome/browser/search/suggestions/image_manager_impl.h:31: class ImageData;
On 2014/08/07 20:33:32, huangs1 wrote:
> Sort alphabetically??

Done.

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
chrome/browser/search/suggestions/image_manager_impl.h:140: std::vector<unsigned
char>* dest);
On 2014/08/07 20:33:32, huangs1 wrote:
> Fix indent.

Done.

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
File chrome/browser/search/suggestions/image_manager_impl_browsertest.cc
(right):

https://codereview.chromium.org/445753004/diff/1/chrome/browser/search/sugges...
chrome/browser/search/suggestions/image_manager_impl_browsertest.cc:138:
/*std::vector<unsigned char> actual;
On 2014/08/07 20:33:32, huangs1 wrote:
> Note comment block?

Done.

https://codereview.chromium.org/445753004/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/445753004/diff/1/chrome/chrome_browser.gypi#n...
chrome/chrome_browser.gypi:1140:
'browser/search/suggestions/image_manager_impl.cc',
On 2014/08/07 20:33:32, huangs1 wrote:
> Sort alphabetically.

Done.

https://codereview.chromium.org/445753004/diff/1/components/suggestions/proto...
File components/suggestions/proto/suggestions.proto (right):

https://codereview.chromium.org/445753004/diff/1/components/suggestions/proto...
components/suggestions/proto/suggestions.proto:55: // ImageData contains the
data to represent a website image (thumbnail,
On 2014/08/07 20:33:32, huangs1 wrote:
> Note that favicon are not JPEG in general, so more work will be needed.

Acknowledged.

[Mathieu, 2014-08-07 21:03:40]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-08-07 21:22:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mathp@chromium.org/445753004/60001

[commit-bot: I haz the power, 2014-08-08 08:33:51]

Change committed as 288260