Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 445753002: [Android] Temporarily suppress RTL start&end check error. (Closed)

Created:
6 years, 4 months ago by Kibeom Kim (inactive)
Modified:
6 years, 4 months ago
Reviewers:
Ted C, gone, newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, gone, aurimas (slooooooooow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Temporarily suppress RTL start&end check error. The newest Android SDK had start&end attributes in non -v17 resources. Temporarily change the checking script from error to warning so that people can continue to work before it is fixed. This should be reverted once the issue is addressed BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287711

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M build/android/gyp/generate_v14_compatible_resources.py View 1 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Kibeom Kim (inactive)
6 years, 4 months ago (2014-08-05 23:34:23 UTC) #1
gone
lgtm
6 years, 4 months ago (2014-08-05 23:34:48 UTC) #2
Kibeom Kim (inactive)
The CQ bit was checked by kkimlabs@chromium.org
6 years, 4 months ago (2014-08-05 23:35:21 UTC) #3
Kibeom Kim (inactive)
The CQ bit was unchecked by kkimlabs@chromium.org
6 years, 4 months ago (2014-08-05 23:35:29 UTC) #4
Kibeom Kim (inactive)
The CQ bit was checked by kkimlabs@chromium.org
6 years, 4 months ago (2014-08-05 23:35:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/445753002/1
6 years, 4 months ago (2014-08-05 23:36:39 UTC) #6
commit-bot: I haz the power
Change committed as 287711
6 years, 4 months ago (2014-08-06 06:37:44 UTC) #7
Kibeom Kim (inactive)
6 years, 3 months ago (2014-09-09 21:36:55 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/555253004/ by kkimlabs@chromium.org.

The reason for reverting is: Android SDK fixed the issue, so we can convert back
from warning to error..

Powered by Google App Engine
This is Rietveld 408576698