Enabling validation code in serialization and adding serialization to fuzzer

include/core/SkFlattenableSerialization.h

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkFlattenableSerialization_DEFINED
 #define SkFlattenableSerialization_DEFINED
 
-#include "SkTypes.h"
+#include "SkFlattenable.h"
 
 class SkData;
-class SkFlattenable;
 
-SK_API SkData* SkSerializeFlattenable(SkFlattenable*);
-SK_API SkFlattenable* SkDeserializeFlattenable(const void* data, size_t size);
+SK_API SkData* SkValidatingSerializeFlattenable(SkFlattenable*);
+SK_API SkFlattenable* SkValidatingDeserializeFlattenable(const void* data, size_t size,
+                                                         SkFlattenable::Type type);
+
+// Temporary fix for canary build

[Stephen White, 2013/10/25 16:13:11]

Not sure I understand this. Is this changing all serialization to be temporarily
validating?

BTW the usual way to land these type of two-sided patches is to hide the old
behaviour behind an #ifdef. Is that not possible here?

[mtklein, 2013/10/25 16:17:31]

I think this is just a name refinement.  Sk{Serialize,Deserialize}Flattenable
were introduced with validation in mind.

[Stephen White, 2013/10/25 16:36:21]

Ah, ok. Thanks.

[sugoi1, 2013/10/25 17:15:04]

FYI, there's only a single user of these functions, and it's the ParamTraits
class for SkImagefilter, and it's usage is currently hidden behind a flag in
chrome.

+#define SkSerializeFlattenable(flattenable) \
+SkValidatingSerializeFlattenable(flattenable)
+
+#define SkDeserializeFlattenable(data, size) \
+SkValidatingDeserializeFlattenable(data, size, SkFlattenable::kSkImageFilter_Type)
 
 #endif