Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 445713002: GN bootstrap.py: fixed cross-compile, etc. (Closed)

Created:
6 years, 4 months ago by kal
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GN bootstrap.py: fixed cross-compile, etc. + Use env var LD (default to CXX) + Exclude run_all_unittests.cc from build NOTRY=true R=brettw@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288001

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M tools/gn/bootstrap/bootstrap.py View 4 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kal
6 years, 4 months ago (2014-08-05 21:33:35 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-08-06 22:28:07 UTC) #2
kal
The CQ bit was checked by kcconley@gmail.com
6 years, 4 months ago (2014-08-07 06:18:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kcconley@gmail.com/445713002/1
6 years, 4 months ago (2014-08-07 06:19:33 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 07:55:17 UTC) #5
Message was sent while issue was closed.
Change committed as 288001

Powered by Google App Engine
This is Rietveld 408576698