[GCM] Exposing persistence of account mappings in GCM Driver

[GCM] Exposing persistence of account mappings in GCM Driver

* Enables GCMAccountMapper (patches to come) to persist AccountMappings
  in GCMStore by calling GCMDriver.
* Passes UpdateAccountMapping and RemoveAccountMapping through:
  * GCMDriverDesktop
  * GCMDriverDesktop::IOWorker
  * GCMClientImpl

BUG=374969
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290928

[fgorski, 2014-08-07 21:46:01]

PTAL.

The method implementations are either empty or pass through (and one way, as I
skipped callbacks based on design discussion) and that is why I am not
introducing tests here. GCMStoreImpl already has relevant tests. I was looking
into adding verification code to FakeGCMClient, but it does not have any right
now, and in doing so we would confuse its purpose.

[Nicolas Zea, 2014-08-11 18:21:05]

LGTM with a comment

https://codereview.chromium.org/445683003/diff/20001/components/gcm_driver/gc...
File components/gcm_driver/gcm_driver_desktop.cc (right):

https://codereview.chromium.org/445683003/diff/20001/components/gcm_driver/gc...
components/gcm_driver/gcm_driver_desktop.cc:379: if (gcm_client_.get())
Shouldn't we always have a gcm_client_ at this point?

[fgorski, 2014-08-20 18:28:55]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2014-08-20 18:29:07]

https://codereview.chromium.org/445683003/diff/20001/components/gcm_driver/gc...
File components/gcm_driver/gcm_driver_desktop.cc (right):

https://codereview.chromium.org/445683003/diff/20001/components/gcm_driver/gc...
components/gcm_driver/gcm_driver_desktop.cc:379: if (gcm_client_.get())
On 2014/08/11 18:21:05, Nicolas Zea wrote:
> Shouldn't we always have a gcm_client_ at this point?

It shouldn't be after Initialize was called. I am doing this to match the
defensive style of this class. We can revisit it later if you think it is an
overkill.

[commit-bot: I haz the power, 2014-08-20 18:31:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fgorski@chromium.org/445683003/20001

[commit-bot: I haz the power, 2014-08-20 20:04:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-20 21:21:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-20 21:21:53]

Try jobs failed on following builders:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[fgorski, 2014-08-20 21:35:50]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2014-08-20 21:37:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fgorski@chromium.org/445683003/20001

[commit-bot: I haz the power, 2014-08-20 22:34:32]

Committed patchset #2 (20001) as 290928