Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 445623003: Surface the audited last usage time in a user readable string. (Closed)

Created:
6 years, 4 months ago by Daniel Nishi
Modified:
6 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
scheib, chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Surface the audited last usage time in a user readable string on the Website Settings options page. Image: http://imgur.com/LzbuTsJ BUG=372607 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287979

Patch Set 1 #

Total comments: 4

Patch Set 2 : Moved the font changes up to #origin-list. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M chrome/browser/resources/options/website_settings.css View 1 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/website_settings_handler.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Daniel Nishi
bauerb: PTAL.
6 years, 4 months ago (2014-08-05 17:09:11 UTC) #1
Bernhard Bauer
https://codereview.chromium.org/445623003/diff/1/chrome/browser/resources/options/website_settings.css File chrome/browser/resources/options/website_settings.css (right): https://codereview.chromium.org/445623003/diff/1/chrome/browser/resources/options/website_settings.css#newcode26 chrome/browser/resources/options/website_settings.css:26: font-family: Noto Sans; Is this necessary? What font would ...
6 years, 4 months ago (2014-08-05 17:10:36 UTC) #2
Daniel Nishi
https://codereview.chromium.org/445623003/diff/1/chrome/browser/resources/options/website_settings.css File chrome/browser/resources/options/website_settings.css (right): https://codereview.chromium.org/445623003/diff/1/chrome/browser/resources/options/website_settings.css#newcode26 chrome/browser/resources/options/website_settings.css:26: font-family: Noto Sans; On 2014/08/05 17:10:36, Bernhard Bauer wrote: ...
6 years, 4 months ago (2014-08-05 17:16:59 UTC) #3
Bernhard Bauer
https://codereview.chromium.org/445623003/diff/1/chrome/browser/resources/options/website_settings.css File chrome/browser/resources/options/website_settings.css (right): https://codereview.chromium.org/445623003/diff/1/chrome/browser/resources/options/website_settings.css#newcode26 chrome/browser/resources/options/website_settings.css:26: font-family: Noto Sans; On 2014/08/05 17:16:59, Daniel Nishi wrote: ...
6 years, 4 months ago (2014-08-06 10:24:48 UTC) #4
Daniel Nishi
https://codereview.chromium.org/445623003/diff/1/chrome/browser/resources/options/website_settings.css File chrome/browser/resources/options/website_settings.css (right): https://codereview.chromium.org/445623003/diff/1/chrome/browser/resources/options/website_settings.css#newcode26 chrome/browser/resources/options/website_settings.css:26: font-family: Noto Sans; On 2014/08/06 10:24:48, Bernhard Bauer wrote: ...
6 years, 4 months ago (2014-08-06 18:02:18 UTC) #5
Bernhard Bauer
On 2014/08/06 18:02:18, Daniel Nishi wrote: > https://codereview.chromium.org/445623003/diff/1/chrome/browser/resources/options/website_settings.css > File chrome/browser/resources/options/website_settings.css (right): > > https://codereview.chromium.org/445623003/diff/1/chrome/browser/resources/options/website_settings.css#newcode26 ...
6 years, 4 months ago (2014-08-06 18:13:11 UTC) #6
Daniel Nishi
The CQ bit was checked by dhnishi@chromium.org
6 years, 4 months ago (2014-08-06 21:15:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhnishi@chromium.org/445623003/20001
6 years, 4 months ago (2014-08-06 21:17:37 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-07 01:47:34 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 07:09:05 UTC) #10
Message was sent while issue was closed.
Change committed as 287979

Powered by Google App Engine
This is Rietveld 408576698