Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 445573002: Fix GMOCK warnings in AutofillExternalDelegateUnitTest (Closed)

Created:
6 years, 4 months ago by Jiang Jiang
Modified:
6 years, 4 months ago
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix GMOCK warnings in AutofillExternalDelegateUnitTest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M components/autofill/core/browser/autofill_external_delegate_unittest.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jiang Jiang
Can any of you please take a look?
6 years, 4 months ago (2014-08-05 13:08:42 UTC) #1
Evan Stade
lgtm note the other way to do this is to wrap autofill_client_ with NiceMock
6 years, 4 months ago (2014-08-05 17:28:42 UTC) #2
Jiang Jiang
The CQ bit was checked by jiangj@opera.com
6 years, 4 months ago (2014-08-05 17:36:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/445573002/1
6 years, 4 months ago (2014-08-05 17:37:52 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-05 20:56:46 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 21:06:26 UTC) #6
Message was sent while issue was closed.
Change committed as 287598

Powered by Google App Engine
This is Rietveld 408576698