tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py - Issue 445503004: Dismiss multiple error dialogs when running tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

Issue 445503004: Dismiss multiple error dialogs when running tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix Sami's comment Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

index 0fba7e7602c54de55a0896c9470adcc9577d3b6b..9efe747f0f024aebb2f1357408651772195f94fd 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

@@ -273,7 +273,11 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

# If we have no existing tabs start with a blank page since default

# startup with the NTP can lead to race conditions with Telemetry

url = 'about:blank'

- self._adb.device().old_interface.DismissCrashDialogIfNeeded()

+ # Dismiss any error dialogs. Limit the number in case we have an error loop

+ # or we are failing to dismiss.

+ for _ in xrange(10):

+ if not self._adb.device().old_interface.DismissCrashDialogIfNeeded():

+ break

self._adb.device().StartActivity(

intent.Intent(package=self._backend_settings.package,

activity=self._backend_settings.activity,

« no previous file with comments | « build/android/pylib/instrumentation/test_runner.py ('k') | no next file » | no next file with comments »