Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 445503003: Update easy unlock settings UI. (Closed)

Created:
6 years, 4 months ago by xiyuan
Modified:
6 years, 4 months ago
Reviewers:
tbarzic
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org, Ilya Sherman
Project:
chromium
Visibility:
Public.

Description

Update easy unlock settings UI. BUG=397356 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288183

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : use hard coded phone model name #

Total comments: 2

Patch Set 4 : offline and server error ui #

Patch Set 5 : add spinner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -53 lines) Patch
M chrome/app/chromeos_strings.grdp View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +30 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 2 1 chunk +10 lines, -23 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A + chrome/browser/resources/options/easy_unlock_turn_off_overlay.css View 1 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/browser/resources/options/easy_unlock_turn_off_overlay.html View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/browser/resources/options/easy_unlock_turn_off_overlay.js View 1 2 3 4 1 chunk +137 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options.html View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options.js View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options_bundle.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 3 chunks +18 lines, -11 lines 0 comments Download
M chrome/common/url_constants.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/url_constants.cc View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
xiyuan
Not wired with real settings yet. Screenshots will be uploaded to bug.
6 years, 4 months ago (2014-08-05 15:38:50 UTC) #1
Ilya Sherman
Drive-by nit: https://codereview.chromium.org/445503003/diff/40001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (left): https://codereview.chromium.org/445503003/diff/40001/chrome/app/generated_resources.grd#oldcode9918 chrome/app/generated_resources.grd:9918: Easy Unlock nit: The mocks have a ...
6 years, 4 months ago (2014-08-05 18:51:14 UTC) #2
xiyuan
Tony, can you review this when you have time? I would like to get the ...
6 years, 4 months ago (2014-08-07 19:37:00 UTC) #3
tbarzic
lgtm
6 years, 4 months ago (2014-08-07 19:49:17 UTC) #4
xiyuan
The CQ bit was checked by xiyuan@chromium.org
6 years, 4 months ago (2014-08-07 19:50:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/445503003/100001
6 years, 4 months ago (2014-08-07 19:57:26 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 00:53:39 UTC) #7
Message was sent while issue was closed. 
Change committed as 288183

Powered by Google App Engine
This is Rietveld 408576698