Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2283)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.h

Issue 445493002: Delete the Safe Browsing V2 interstitial and Finch trial (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed JS/HTML Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
index 79b6b410aca685fd58ee0495b2d59ff17a0fb718..002d0d1a012aaf17cbb5bf1b094be4f209b3a503 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
@@ -83,9 +83,7 @@ class SafeBrowsingBlockingPage : public content::InterstitialPageDelegate {
virtual void OnDontProceed() OVERRIDE;
protected:
- template <class TestSBInterstitialPage>
friend class SafeBrowsingBlockingPageTest;
- template <class TestSBInterstitialPage>
FRIEND_TEST_ALL_PREFIXES(SafeBrowsingBlockingPageTest,
ProceedThenDontProceed);
@@ -106,10 +104,8 @@ class SafeBrowsingBlockingPage : public content::InterstitialPageDelegate {
return interstitial_page_;
}
- template <class TestSBInterstitialPage>
FRIEND_TEST_ALL_PREFIXES(SafeBrowsingBlockingPageTest,
MalwareReportsTransitionDisabled);
- template <class TestSBInterstitialPage>
FRIEND_TEST_ALL_PREFIXES(SafeBrowsingBlockingPageTest,
MalwareReportsToggling);
@@ -224,35 +220,6 @@ class SafeBrowsingBlockingPage : public content::InterstitialPageDelegate {
DISALLOW_COPY_AND_ASSIGN(SafeBrowsingBlockingPage);
};
-class SafeBrowsingBlockingPageV2 : public SafeBrowsingBlockingPage {
- public:
- // Don't instanciate this class directly, use ShowBlockingPage instead.
- SafeBrowsingBlockingPageV2(SafeBrowsingUIManager* ui_manager,
- content::WebContents* web_contents,
- const UnsafeResourceList& unsafe_resources);
-
- // InterstitialPageDelegate method:
- virtual std::string GetHTMLContents() OVERRIDE;
-
- private:
- // Fills the passed dictionary with the strings passed to JS Template when
- // creating the HTML.
- void PopulateMultipleThreatStringDictionary(base::DictionaryValue* strings);
- void PopulateMalwareStringDictionary(base::DictionaryValue* strings);
- void PopulatePhishingStringDictionary(base::DictionaryValue* strings);
-
- // A helper method used by the Populate methods above used to populate common
- // fields.
- void PopulateStringDictionary(base::DictionaryValue* strings,
- const base::string16& title,
- const base::string16& headline,
- const base::string16& description1,
- const base::string16& description2,
- const base::string16& description3);
-
- DISALLOW_COPY_AND_ASSIGN(SafeBrowsingBlockingPageV2);
-};
-
class SafeBrowsingBlockingPageV3 : public SafeBrowsingBlockingPage {
public:
SafeBrowsingBlockingPageV3(SafeBrowsingUIManager* ui_manager,
@@ -268,9 +235,6 @@ class SafeBrowsingBlockingPageV3 : public SafeBrowsingBlockingPage {
void PopulateMalwareLoadTimeData(base::DictionaryValue* load_time_data);
void PopulatePhishingLoadTimeData(base::DictionaryValue* load_time_data);
- // For the M37 FieldTrial: this contains the name of the condition.
- std::string trial_condition_;
-
DISALLOW_COPY_AND_ASSIGN(SafeBrowsingBlockingPageV3);
};

Powered by Google App Engine
This is Rietveld 408576698