Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: chrome/browser/about_flags.cc

Issue 445493002: Delete the Safe Browsing V2 interstitial and Finch trial (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed the SafeBrowsingBlockingPageV3 subclass Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 6b8e4ac970a9e3bd62f36b5bebd8ece6c0af6cf9..d998d63f1ed58b5983115c5c6cf2ee5a878a76a4 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -430,25 +430,6 @@ const Experiment::Choice kAnswersInSuggestChoices[] = {
};
#endif
-// Using independent flags (instead of flag=value flags) to be able to
-// associate the version with a FieldTrial. FieldTrials don't currently support
-// flag=value flags.
-const Experiment::Choice kMalwareInterstitialVersions[] = {
- { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
- { IDS_FLAGS_MALWARE_INTERSTITIAL_VERSION_V2,
- switches::kMalwareInterstitialV2, "" },
- { IDS_FLAGS_MALWARE_INTERSTITIAL_VERSION_V3,
- switches::kMalwareInterstitialV3, "" },
- { IDS_FLAGS_MALWARE_INTERSTITIAL_VERSION_V3_ADVICE,
- switches::kMalwareInterstitialV3Advice, "" },
- { IDS_FLAGS_MALWARE_INTERSTITIAL_VERSION_V3_SOCIAL,
- switches::kMalwareInterstitialV3Social, "" },
- { IDS_FLAGS_MALWARE_INTERSTITIAL_VERSION_V3_NOTRECOMMEND,
- switches::kMalwareInterstitialV3NotRecommend, "" },
- { IDS_FLAGS_MALWARE_INTERSTITIAL_VERSION_V3_HISTORY,
- switches::kMalwareInterstitialV3History, "" },
-};
-
#if defined(OS_CHROMEOS)
const Experiment::Choice kEnableFileManagerMTPChoices[] = {
{ IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
@@ -1869,13 +1850,6 @@ const Experiment kExperiments[] = {
MULTI_VALUE_TYPE(kAnswersInSuggestChoices)
},
#endif
- {
- "malware-interstitial-version",
- IDS_FLAGS_MALWARE_INTERSTITIAL_TRIAL_NAME,
- IDS_FLAGS_MALWARE_INTERSTITIAL_TRIAL_DESCRIPTION,
- kOsAll,
- MULTI_VALUE_TYPE(kMalwareInterstitialVersions)
- },
#if defined(OS_ANDROID)
{
"enable-data-reduction-proxy-dev",

Powered by Google App Engine
This is Rietveld 408576698