Delete the Safe Browsing V2 interstitial and Finch trial

Delete the Safe Browsing V2 interstitial and Finch trial

BUG=396275
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288472

[felt, 2014-08-06 23:42:41]

mattm, dbeam: PTAL. More code deletion for your enjoyment.

Matt, a note: I had to disable
SafeBrowsingBlockingPageBrowserTest.MalwareIframeReportDetails and
SafeBrowsingBlockingPageBrowserTest.ReportingDisabled. Previously they were
disabled for V3 using GetParams(), which was an accident. I will enable them in
a separate CL so that flakiness with those two tests doesn't bounce this whole
CL.

[felt, 2014-08-06 23:44:43]

On 2014/08/06 23:42:41, felt wrote:
> mattm, dbeam: PTAL. More code deletion for your enjoyment.
> 
> Matt, a note: I had to disable
> SafeBrowsingBlockingPageBrowserTest.MalwareIframeReportDetails and
> SafeBrowsingBlockingPageBrowserTest.ReportingDisabled. Previously they were
> disabled for V3 using GetParams(), which was an accident. I will enable them
in
> a separate CL so that flakiness with those two tests doesn't bounce this whole
> CL.

P.S. The trybots don't seem to like the deletion of the .pngs, so I'll separate
the images out into a separate CL once I have an LGTM for this one.

[mattm, 2014-08-07 01:20:28]

lgtm

[Dan Beam, 2014-08-07 03:39:54]

it's like christmas!

https://codereview.chromium.org/445493002/diff/60001/chrome/browser/safe_brow...
File chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
(right):

https://codereview.chromium.org/445493002/diff/60001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc:36: class
TestSafeBrowsingBlockingPageV3 :  public SafeBrowsingBlockingPageV3 {
why isn't this V3 removed?

[felt, 2014-08-07 14:07:26]

https://codereview.chromium.org/445493002/diff/60001/chrome/browser/safe_brow...
File chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
(right):

https://codereview.chromium.org/445493002/diff/60001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc:36: class
TestSafeBrowsingBlockingPageV3 :  public SafeBrowsingBlockingPageV3 {
On 2014/08/07 03:39:53, Dan Beam wrote:
> why isn't this V3 removed?

You mean, rename to TestSafeBrowsingBlockingPage? Done.

[Dan Beam, 2014-08-07 22:05:09]

https://codereview.chromium.org/445493002/diff/120001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_blocking_page.h (right):

https://codereview.chromium.org/445493002/diff/120001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_blocking_page.h:235: class
SafeBrowsingBlockingPageV3 : public SafeBrowsingBlockingPage {
why do we need SafeBrowsingBlockingPageV3 any more?

why not just move SafeBrowsingBlockingPageV3::GetHTMLContents() to
SafeBrowsingBlockingPage::GetHTMLContents()?

[felt, 2014-08-08 00:30:29]

https://codereview.chromium.org/445493002/diff/120001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_blocking_page.h (right):

https://codereview.chromium.org/445493002/diff/120001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_blocking_page.h:235: class
SafeBrowsingBlockingPageV3 : public SafeBrowsingBlockingPage {
On 2014/08/07 22:05:08, Dan Beam wrote:
> why do we need SafeBrowsingBlockingPageV3 any more?
> 
> why not just move SafeBrowsingBlockingPageV3::GetHTMLContents() to
> SafeBrowsingBlockingPage::GetHTMLContents()?

Done.

[Dan Beam, 2014-08-08 02:34:33]

lgtm

https://codereview.chromium.org/445493002/diff/140001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_blocking_page.h (right):

https://codereview.chromium.org/445493002/diff/140001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_blocking_page.h:79: //
InterstitialPageDelegate method:
combine with other methods

https://codereview.chromium.org/445493002/diff/140001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_blocking_page.h:88: //
InterstitialPageDelegate method:
^

https://codereview.chromium.org/445493002/diff/140001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
(right):

https://codereview.chromium.org/445493002/diff/140001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc:36: class
TestSafeBrowsingBlockingPage :  public SafeBrowsingBlockingPage {
nit: 1\s after : before public

[felt, 2014-08-08 02:37:39]

https://codereview.chromium.org/445493002/diff/140001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_blocking_page.h (right):

https://codereview.chromium.org/445493002/diff/140001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_blocking_page.h:79: //
InterstitialPageDelegate method:
On 2014/08/08 02:34:33, Dan Beam wrote:
> combine with other methods

Done, and reordered to be in same order as InterstitialPageDelegate

https://codereview.chromium.org/445493002/diff/140001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_blocking_page.h:88: //
InterstitialPageDelegate method:
On 2014/08/08 02:34:33, Dan Beam wrote:
> ^

Acknowledged.

https://codereview.chromium.org/445493002/diff/140001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
(right):

https://codereview.chromium.org/445493002/diff/140001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc:36: class
TestSafeBrowsingBlockingPage :  public SafeBrowsingBlockingPage {
On 2014/08/08 02:34:33, Dan Beam wrote:
> nit: 1\s after : before public

Done.

[felt, 2014-08-08 02:41:14]

jhawkins: Can I please get an OWNERS review for
chrome/browser/browser_resources.grd? Deleting a single file.

[Dan Beam, 2014-08-08 03:11:36]

On 2014/08/08 02:41:14, felt wrote:
> jhawkins: Can I please get an OWNERS review for
> chrome/browser/browser_resources.grd? Deleting a single file.

eh, you could probably just TBR= this

[James Hawkins, 2014-08-08 08:32:45]

browser_resources.grd LGTM

[felt, 2014-08-08 19:16:46]

On 2014/08/08 08:32:45, James Hawkins wrote:
> browser_resources.grd LGTM

The .png file deletions have been moved to
https://codereview.chromium.org/455943002 so that the rest of the CL can go
through the CQ.

[felt, 2014-08-08 22:45:08]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2014-08-08 22:46:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/felt@chromium.org/445493002/200001

[commit-bot: I haz the power, 2014-08-09 00:03:22]

Change committed as 288472