Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 445473002: Remove ResourceIdCanonicalizer from DriveServiceInterface (Closed)

Created:
6 years, 4 months ago by hashimoto
Modified:
6 years, 4 months ago
Reviewers:
kinaba, tzik
CC:
chromium-reviews, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, tzik, tfarina, nhiroki, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove ResourceIdCanonicalizer from DriveServiceInterface This abstraction was needed to correctly handle test data which was using the old format ID. Now the test data is using the new ID format so it's OK to call CanonicalizeResourceId() directly. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287505

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -84 lines) Patch
M chrome/browser/chromeos/drive/drive_integration_service.cc View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.h View 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation_unittest.cc View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_interface.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc View 6 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/drive/drive_api_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/drive/drive_api_service.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/drive/drive_api_util.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/drive/drive_api_util.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/drive/drive_service_interface.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/drive/dummy_drive_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/drive/dummy_drive_service.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
hashimoto
6 years, 4 months ago (2014-08-05 04:14:52 UTC) #1
kinaba
lgtm!!!
6 years, 4 months ago (2014-08-05 04:21:41 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-05 04:26:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/445473002/20001
6 years, 4 months ago (2014-08-05 04:28:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 06:12:13 UTC) #5
hashimoto
tzik@, could you take a look at this change as an owner of chrome/browser/sync_file_system/
6 years, 4 months ago (2014-08-05 06:13:29 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 06:22:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/3302)
6 years, 4 months ago (2014-08-05 06:22:55 UTC) #8
tzik
lgtm
6 years, 4 months ago (2014-08-05 06:24:09 UTC) #9
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-05 07:20:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/445473002/20001
6 years, 4 months ago (2014-08-05 07:21:53 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 10:09:55 UTC) #12
Message was sent while issue was closed.
Change committed as 287505

Powered by Google App Engine
This is Rietveld 408576698