Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 445443002: Initialize HttpNetworkSession::Params member after r287408. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
wtc, mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, mshelley
Project:
chromium
Visibility:
Public.

Description

Initialize HttpNetworkSession::Params member after r287408. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M net/http/http_network_session.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Lei Zhang
6 years, 4 months ago (2014-08-05 02:40:44 UTC) #1
mattm
lgtm
6 years, 4 months ago (2014-08-05 02:42:37 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-05 02:43:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/445443002/1
6 years, 4 months ago (2014-08-05 02:45:46 UTC) #4
wtc
Patch set 1 LGTM. Thanks!
6 years, 4 months ago (2014-08-05 03:58:54 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 04:12:15 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 04:45:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/builds/3079)
6 years, 4 months ago (2014-08-05 04:45:02 UTC) #8
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-05 07:02:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/445443002/1
6 years, 4 months ago (2014-08-05 07:03:43 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 08:14:23 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 08:53:51 UTC) #12
Message was sent while issue was closed. 
Change committed as 287500

Powered by Google App Engine
This is Rietveld 408576698