Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2947)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

Issue 44543002: Enable touch for autofill popup view (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Improved comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
index a9102669a7741d2f74193e127f9a3f0648a29efd..c5c4c73cc692bbf1cbf31621ca1977158ecb1296 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
@@ -266,7 +266,7 @@ bool AutofillPopupControllerImpl::HandleKeyPressEvent(
return (event.modifiers & content::NativeWebKeyboardEvent::ShiftKey) &&
RemoveSelectedLine();
case ui::VKEY_TAB:
- // A tab press should cause the highlighted line to be selected, but still
+ // A tab press should cause the selected line to be accepted, but still
// return false so the tab key press propagates and changes the cursor
// location.
AcceptSelectedLine();
@@ -290,16 +290,16 @@ void AutofillPopupControllerImpl::UpdateBoundsAndRedrawPopup() {
view_->UpdateBoundsAndRedrawPopup();
}
-void AutofillPopupControllerImpl::MouseHovered(int x, int y) {
+void AutofillPopupControllerImpl::LineSelectedAtPoint(int x, int y) {
SetSelectedLine(LineFromY(y));
}
-void AutofillPopupControllerImpl::MouseClicked(int x, int y) {
- MouseHovered(x, y);
+void AutofillPopupControllerImpl::LineAcceptedAtPoint(int x, int y) {
+ LineSelectedAtPoint(x, y);
AcceptSelectedLine();
}
-void AutofillPopupControllerImpl::MouseExitedPopup() {
+void AutofillPopupControllerImpl::SelectionCleared() {
SetSelectedLine(kNoSelection);
}

Powered by Google App Engine
This is Rietveld 408576698