Enable touch for autofill popup view

chrome/browser/ui/views/autofill/autofill_popup_view_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/autofill/autofill_popup_view_views.h"
 
 #include "chrome/browser/ui/autofill/autofill_popup_controller.h"
 #include "grit/ui_resources.h"
 #include "third_party/WebKit/public/web/WebAutofillClient.h"
 #include "ui/base/resource/resource_bundle.h"
@@ skipping 144 matching lines @@
   // receive an OnMouseReleased event just after showing. This breaks the mouse
   // capture, so restart capturing here.
   if (controller_->hide_on_outside_click() && GetWidget())
     GetWidget()->SetCapture(this);
 
   // We only care about the left click.
   if (event.IsOnlyLeftMouseButton() && HitTestPoint(event.location()))
     controller_->MouseClicked(event.x(), event.y());
 }
 
+void AutofillPopupViewViews::OnGestureEvent(ui::GestureEvent* event) {
+  if (!controller_)
+    return;
+
+  switch (event->type()) {
+    case ui::ET_GESTURE_TAP_DOWN:
+    case ui::ET_GESTURE_SCROLL_UPDATE:
+      if (HitTestPoint(event->location()))
+        controller_->MouseHovered(event->x(), event->y());

[Rick Byers, 2013/10/25 17:22:23]

nit: would be nice to update these method names to make it clear they're no
longer specific to mouse.  Maybe:
MouseHovered -> HighlightAt
MouseExitedPopup -> Dismiss
MouseClicked -> ActivateAt

or something like that.

+      else
+        controller_->MouseExitedPopup();
+      break;
+    case ui::ET_GESTURE_TAP:
+    case ui::ET_GESTURE_SCROLL_END:
+      if (HitTestPoint(event->location()))
+        controller_->MouseClicked(event->x(), event->y());
+      else
+        controller_->MouseExitedPopup();
+      break;
+    case ui::ET_GESTURE_TAP_CANCEL:
+    case ui::ET_SCROLL_FLING_START:
+      controller_->MouseExitedPopup();
+    default:
+      break;
+  }
+  event->SetHandled();

[Dan Beam, 2013/10/25 18:38:23]

don't you only want to set the event handled in some cases?

[mohsen, 2013/10/25 21:36:41]

I think it is not making any difference in this case, because we don't have a
hierarchy of Views here. But, I've limited the SetHandled() to consumed events,
as it seems generally more correct.

+}
+
 void AutofillPopupViewViews::OnWidgetBoundsChanged(
     views::Widget* widget,
     const gfx::Rect& new_bounds) {
   DCHECK_EQ(widget, observing_widget_);
   controller_->Hide();
 }
 
 void AutofillPopupViewViews::Show() {
   if (!GetWidget()) {
     observing_widget_->AddObserver(this);
@@ skipping 98 matching lines @@
 
   // If the top level widget can't be found, cancel the popup since we can't
   // fully set it up.
   if (!observing_widget)
     return NULL;
 
   return new AutofillPopupViewViews(controller, observing_widget);
 }
 
 }  // namespace autofill