Enable touch for autofill popup view

chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/autofill/autofill_popup_view.h"
 #include "components/autofill/core/browser/autofill_popup_delegate.h"
 #include "content/public/browser/native_web_keyboard_event.h"
 #include "grit/webkit_resources.h"
 #include "third_party/WebKit/public/web/WebAutofillClient.h"
 #include "ui/events/event.h"
 #include "ui/gfx/display.h"
 #include "ui/gfx/rect_conversions.h"
 #include "ui/gfx/screen.h"
 #include "ui/gfx/text_elider.h"
 #include "ui/gfx/vector2d.h"
 
 using base::WeakPtr;
 using WebKit::WebAutofillClient;
 
 namespace autofill {
 namespace {
 
-// Used to indicate that no line is currently selected by the user.
-const int kNoSelection = -1;
+// Used to indicate that no line is currently preselected by the user.
+const int kNoPreselection = -1;
 
 // The vertical height of each row in pixels.
 const size_t kRowHeight = 24;
 
 // The vertical height of a separator in pixels.
 const size_t kSeparatorHeight = 1;
 
 #if !defined(OS_ANDROID)
 // Size difference between name and subtext in pixels.
 const int kLabelFontSizeDelta = -2;
@@ skipping 199 matching lines @@
   // The view has already been destroyed so clear the reference to it.
   view_ = NULL;
 
   Hide();
 }
 
 bool AutofillPopupControllerImpl::HandleKeyPressEvent(
     const content::NativeWebKeyboardEvent& event) {
   switch (event.windowsKeyCode) {
     case ui::VKEY_UP:
-      SelectPreviousLine();
+      PreselectPreviousLine();
       return true;
     case ui::VKEY_DOWN:
-      SelectNextLine();
+      PreselectNextLine();
       return true;
     case ui::VKEY_PRIOR:  // Page up.
-      SetSelectedLine(0);
+      SetPreselectedLine(0);
       return true;
     case ui::VKEY_NEXT:  // Page down.
-      SetSelectedLine(names().size() - 1);
+      SetPreselectedLine(names().size() - 1);
       return true;
     case ui::VKEY_ESCAPE:
       Hide();
       return true;
     case ui::VKEY_DELETE:
       return (event.modifiers & content::NativeWebKeyboardEvent::ShiftKey) &&
-             RemoveSelectedLine();
+             RemovePreselectedLine();
     case ui::VKEY_TAB:
-      // A tab press should cause the highlighted line to be selected, but still
+      // A tab press should cause the preselected line to be selected, but still
       // return false so the tab key press propagates and changes the cursor
       // location.
-      AcceptSelectedLine();
+      AcceptPreselectedLine();
       return false;
     case ui::VKEY_RETURN:
-      return AcceptSelectedLine();
+      return AcceptPreselectedLine();
     default:
       return false;
   }
 }
 
 void AutofillPopupControllerImpl::UpdateBoundsAndRedrawPopup() {
 #if !defined(OS_ANDROID)
   // TODO(csharp): Since UpdatePopupBounds can change the position of the popup,
   // the popup could end up jumping from above the element to below it.
   // It is unclear if it is better to keep the popup where it was, or if it
   // should try and move to its desired position.
   UpdatePopupBounds();
 #endif
 
   view_->UpdateBoundsAndRedrawPopup();
 }
 
-void AutofillPopupControllerImpl::MouseHovered(int x, int y) {
-  SetSelectedLine(LineFromY(y));
+void AutofillPopupControllerImpl::PointPreselected(int x, int y) {
+  SetPreselectedLine(LineFromY(y));
 }
 
-void AutofillPopupControllerImpl::MouseClicked(int x, int y) {
-  MouseHovered(x, y);
-  AcceptSelectedLine();
+void AutofillPopupControllerImpl::PointSelected(int x, int y) {
+  PointPreselected(x, y);
+  AcceptPreselectedLine();
 }
 
-void AutofillPopupControllerImpl::MouseExitedPopup() {
-  SetSelectedLine(kNoSelection);
+void AutofillPopupControllerImpl::PreselectionCleared() {
+  SetPreselectedLine(kNoPreselection);
 }
 
 bool AutofillPopupControllerImpl::ShouldRepostEvent(
     const ui::MouseEvent& event) {
   return delegate_->ShouldRepostEvent(event);
 }
 
 void AutofillPopupControllerImpl::AcceptSuggestion(size_t index) {
   delegate_->DidAcceptSuggestion(full_names_[index], identifiers_[index]);
 }
@@ skipping 82 matching lines @@
     return warning_font_;
 
   return name_font_;
 }
 
 const gfx::Font& AutofillPopupControllerImpl::subtext_font() const {
   return subtext_font_;
 }
 #endif
 
-int AutofillPopupControllerImpl::selected_line() const {
-  return selected_line_;
+int AutofillPopupControllerImpl::preselected_line() const {
+  return preselected_line_;
 }
 
 void AutofillPopupControllerImpl::set_hide_on_outside_click(
     bool hide_on_outside_click) {
   hide_on_outside_click_ = hide_on_outside_click;
 }
 
-void AutofillPopupControllerImpl::SetSelectedLine(int selected_line) {
-  if (selected_line_ == selected_line)
+void AutofillPopupControllerImpl::SetPreselectedLine(int preselected_line) {
+  if (preselected_line_ == preselected_line)
     return;
 
-  if (selected_line_ != kNoSelection &&
-      static_cast<size_t>(selected_line_) < identifiers_.size())
-    InvalidateRow(selected_line_);
+  if (preselected_line_ != kNoPreselection &&
+      static_cast<size_t>(preselected_line_) < identifiers_.size())
+    InvalidateRow(preselected_line_);
 
-  if (selected_line != kNoSelection)
-    InvalidateRow(selected_line);
+  if (preselected_line != kNoPreselection)
+    InvalidateRow(preselected_line);
 
-  selected_line_ = selected_line;
+  preselected_line_ = preselected_line;
 
-  if (selected_line_ != kNoSelection)
-    delegate_->DidSelectSuggestion(identifiers_[selected_line_]);
+  if (preselected_line_ != kNoPreselection)
+    delegate_->DidPreselectSuggestion(identifiers_[preselected_line_]);
   else
     delegate_->ClearPreviewedForm();
 }
 
-void AutofillPopupControllerImpl::SelectNextLine() {
-  int new_selected_line = selected_line_ + 1;
+void AutofillPopupControllerImpl::PreselectNextLine() {
+  int new_preselected_line = preselected_line_ + 1;
 
   // Skip over any lines that can't be selected.
-  while (static_cast<size_t>(new_selected_line) < names_.size() &&
-         !CanAccept(identifiers()[new_selected_line])) {
-    ++new_selected_line;
+  while (static_cast<size_t>(new_preselected_line) < names_.size() &&
+         !CanAccept(identifiers()[new_preselected_line])) {
+    ++new_preselected_line;
   }
 
-  if (new_selected_line >= static_cast<int>(names_.size()))
-    new_selected_line = 0;
+  if (new_preselected_line >= static_cast<int>(names_.size()))
+    new_preselected_line = 0;
 
-  SetSelectedLine(new_selected_line);
+  SetPreselectedLine(new_preselected_line);
 }
 
-void AutofillPopupControllerImpl::SelectPreviousLine() {
-  int new_selected_line = selected_line_ - 1;
+void AutofillPopupControllerImpl::PreselectPreviousLine() {
+  int new_preselected_line = preselected_line_ - 1;
 
   // Skip over any lines that can't be selected.
-  while (new_selected_line > kNoSelection &&
-         !CanAccept(identifiers()[new_selected_line])) {
-    --new_selected_line;
+  while (new_preselected_line > kNoPreselection &&
+         !CanAccept(identifiers()[new_preselected_line])) {
+    --new_preselected_line;
   }
 
-  if (new_selected_line <= kNoSelection)
-    new_selected_line = names_.size() - 1;
+  if (new_preselected_line <= kNoPreselection)
+    new_preselected_line = names_.size() - 1;
 
-  SetSelectedLine(new_selected_line);
+  SetPreselectedLine(new_preselected_line);
 }
 
-bool AutofillPopupControllerImpl::AcceptSelectedLine() {
-  if (selected_line_ == kNoSelection)
+bool AutofillPopupControllerImpl::AcceptPreselectedLine() {
+  if (preselected_line_ == kNoPreselection)
     return false;
 
-  DCHECK_GE(selected_line_, 0);
-  DCHECK_LT(selected_line_, static_cast<int>(names_.size()));
+  DCHECK_GE(preselected_line_, 0);
+  DCHECK_LT(preselected_line_, static_cast<int>(names_.size()));
 
-  if (!CanAccept(identifiers_[selected_line_]))
+  if (!CanAccept(identifiers_[preselected_line_]))
     return false;
 
-  AcceptSuggestion(selected_line_);
+  AcceptSuggestion(preselected_line_);
   return true;
 }
 
-bool AutofillPopupControllerImpl::RemoveSelectedLine() {
-  if (selected_line_ == kNoSelection)
+bool AutofillPopupControllerImpl::RemovePreselectedLine() {
+  if (preselected_line_ == kNoPreselection)
     return false;
 
-  DCHECK_GE(selected_line_, 0);
-  DCHECK_LT(selected_line_, static_cast<int>(names_.size()));
+  DCHECK_GE(preselected_line_, 0);
+  DCHECK_LT(preselected_line_, static_cast<int>(names_.size()));
 
-  if (!CanDelete(selected_line_))
+  if (!CanDelete(preselected_line_))
     return false;
 
-  delegate_->RemoveSuggestion(full_names_[selected_line_],
-                              identifiers_[selected_line_]);
+  delegate_->RemoveSuggestion(full_names_[preselected_line_],
+                              identifiers_[preselected_line_]);
 
   // Remove the deleted element.
-  names_.erase(names_.begin() + selected_line_);
-  full_names_.erase(full_names_.begin() + selected_line_);
-  subtexts_.erase(subtexts_.begin() + selected_line_);
-  icons_.erase(icons_.begin() + selected_line_);
-  identifiers_.erase(identifiers_.begin() + selected_line_);
+  names_.erase(names_.begin() + preselected_line_);
+  full_names_.erase(full_names_.begin() + preselected_line_);
+  subtexts_.erase(subtexts_.begin() + preselected_line_);
+  icons_.erase(icons_.begin() + preselected_line_);
+  identifiers_.erase(identifiers_.begin() + preselected_line_);
 
-  SetSelectedLine(kNoSelection);
+  SetPreselectedLine(kNoPreselection);
 
   if (HasSuggestions()) {
     delegate_->ClearPreviewedForm();
     UpdateBoundsAndRedrawPopup();
   } else {
     Hide();
   }
 
   return true;
 }
 
 int AutofillPopupControllerImpl::LineFromY(int y) {
   int current_height = AutofillPopupView::kBorderThickness;
 
   for (size_t i = 0; i < identifiers().size(); ++i) {
     current_height += GetRowHeightFromId(identifiers()[i]);
 
     if (y <= current_height)
       return i;
   }
 
-  // The y value goes beyond the popup so stop the selection at the last line.
+  // The y value goes beyond the popup so stop the preselection at the last
+  // line.
   return identifiers().size() - 1;
 }
 
 int AutofillPopupControllerImpl::GetRowHeightFromId(int identifier) const {
   if (identifier == WebAutofillClient::MenuItemIDSeparator)
     return kSeparatorHeight;
 
   return kRowHeight;
 }
 
@@ skipping 126 matching lines @@
   // and this will cause flickering.
 
   popup_bounds_ = gfx::Rect();
 
   names_.clear();
   subtexts_.clear();
   icons_.clear();
   identifiers_.clear();
   full_names_.clear();
 
-  selected_line_ = kNoSelection;
+  preselected_line_ = kNoPreselection;
 }
 
 const gfx::Rect AutofillPopupControllerImpl::RoundedElementBounds() const {
   return gfx::ToEnclosingRect(element_bounds_);
 }
 
 gfx::Display AutofillPopupControllerImpl::GetDisplayNearestPoint(
     const gfx::Point& point) const {
   return gfx::Screen::GetScreenFor(container_view())->GetDisplayNearestPoint(
       point);
@@ skipping 55 matching lines @@
     // The popup can appear below the field.
     return std::make_pair(bottom_growth_start, popup_required_height);
   } else {
     // The popup must appear above the field.
     return std::make_pair(top_growth_end - popup_required_height,
                           popup_required_height);
   }
 }
 
 }  // namespace autofill