Creating a framework for suppressing pollution of the profiler data

base/threading/worker_pool_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/threading/worker_pool_posix.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/debug/trace_event.h"
 #include "base/lazy_instance.h"
@@ skipping 77 matching lines @@
   PlatformThread::SetName(name.c_str());
 
   for (;;) {
     PendingTask pending_task = pool_->WaitForTask();
     if (pending_task.task.is_null())
       break;
     TRACE_EVENT2("toplevel", "WorkerThread::ThreadMain::Run",
         "src_file", pending_task.posted_from.file_name(),
         "src_func", pending_task.posted_from.function_name());
 
-    TrackedTime start_time =
-        tracked_objects::ThreadData::NowForStartOfRun(pending_task.birth_tally);
-
+    tracked_objects::TaskStopwatch stopwatch;
+    stopwatch.Start(tracked_objects::ThreadData::NowForStartOfRun(
+        pending_task.birth_tally));
     pending_task.task.Run();
+    stopwatch.Stop(tracked_objects::ThreadData::NowForEndOfRun());
 
     tracked_objects::ThreadData::TallyRunOnWorkerThreadIfTracking(
         pending_task.birth_tally, TrackedTime(pending_task.time_posted),

[jar (doing other things), 2014/09/02 16:52:16]

*IF* you pushed the Stop() call into TallyRunOnWorkerThreadIfTracking() then it
*might* be better to construct this TrackedTime() before you created/started the
stop watch.  I don't know how long the conversion takes :-/.  It might not be
that bad... but on some platforms, 64bit arithmetic calls are done via slow
library calls :-(.

[vadimt, 2014/09/02 22:41:37]

IF ;-)

-        start_time, tracked_objects::ThreadData::NowForEndOfRun());
+        stopwatch);
   }
 
   // The WorkerThread is non-joinable, so it deletes itself.
   delete this;
 }
 
 }  // namespace
 
 // static
 bool WorkerPool::PostTask(const tracked_objects::Location& from_here,
@@ skipping 77 matching lines @@
       return PendingTask(FROM_HERE, base::Closure());
     }
   }
 
   PendingTask pending_task = pending_tasks_.front();
   pending_tasks_.pop();
   return pending_task;
 }
 
 }  // namespace base