Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: base/debug/task_annotator.cc

Issue 445413003: Creating a framework for suppressing pollution of the profiler data (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing unit tests again. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | base/profiler/scoped_profile.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/debug/task_annotator.h" 5 #include "base/debug/task_annotator.h"
6 6
7 #include "base/debug/alias.h" 7 #include "base/debug/alias.h"
8 #include "base/debug/trace_event.h" 8 #include "base/debug/trace_event.h"
9 #include "base/pending_task.h" 9 #include "base/pending_task.h"
10 #include "base/tracked_objects.h" 10 #include "base/tracked_objects.h"
(...skipping 10 matching lines...) Expand all
21 void TaskAnnotator::DidQueueTask(const char* queue_function, 21 void TaskAnnotator::DidQueueTask(const char* queue_function,
22 const PendingTask& pending_task) { 22 const PendingTask& pending_task) {
23 TRACE_EVENT_FLOW_BEGIN0(TRACE_DISABLED_BY_DEFAULT("toplevel.flow"), 23 TRACE_EVENT_FLOW_BEGIN0(TRACE_DISABLED_BY_DEFAULT("toplevel.flow"),
24 queue_function, 24 queue_function,
25 TRACE_ID_MANGLE(GetTaskTraceID(pending_task))); 25 TRACE_ID_MANGLE(GetTaskTraceID(pending_task)));
26 } 26 }
27 27
28 void TaskAnnotator::RunTask(const char* queue_function, 28 void TaskAnnotator::RunTask(const char* queue_function,
29 const char* run_function, 29 const char* run_function,
30 const PendingTask& pending_task) { 30 const PendingTask& pending_task) {
31 tracked_objects::TrackedTime start_time = 31 tracked_objects::ThreadData::PrepareForStartOfRun(pending_task.birth_tally);
32 tracked_objects::ThreadData::NowForStartOfRun(pending_task.birth_tally); 32 tracked_objects::TaskStopwatch stopwatch;
33 tracked_objects::Duration queue_duration = 33 tracked_objects::Duration queue_duration =
34 start_time - pending_task.EffectiveTimePosted(); 34 stopwatch.StartTime() - pending_task.EffectiveTimePosted();
35 35
36 TRACE_EVENT_FLOW_END1(TRACE_DISABLED_BY_DEFAULT("toplevel.flow"), 36 TRACE_EVENT_FLOW_END1(TRACE_DISABLED_BY_DEFAULT("toplevel.flow"),
37 queue_function, 37 queue_function,
38 TRACE_ID_MANGLE(GetTaskTraceID(pending_task)), 38 TRACE_ID_MANGLE(GetTaskTraceID(pending_task)),
39 "queue_duration", 39 "queue_duration",
40 queue_duration.InMilliseconds()); 40 queue_duration.InMilliseconds());
41 41
42 // When tracing memory for posted tasks it's more valuable to attribute the 42 // When tracing memory for posted tasks it's more valuable to attribute the
43 // memory allocations to the source function than generically to the task 43 // memory allocations to the source function than generically to the task
44 // runner. 44 // runner.
45 TRACE_EVENT_WITH_MEMORY_TAG2( 45 TRACE_EVENT_WITH_MEMORY_TAG2(
46 "toplevel", 46 "toplevel",
47 run_function, 47 run_function,
48 pending_task.posted_from.function_name(), // Name for memory tracking. 48 pending_task.posted_from.function_name(), // Name for memory tracking.
49 "src_file", 49 "src_file",
50 pending_task.posted_from.file_name(), 50 pending_task.posted_from.file_name(),
51 "src_func", 51 "src_func",
52 pending_task.posted_from.function_name()); 52 pending_task.posted_from.function_name());
53 53
54 // Before running the task, store the program counter where it was posted 54 // Before running the task, store the program counter where it was posted
55 // and deliberately alias it to ensure it is on the stack if the task 55 // and deliberately alias it to ensure it is on the stack if the task
56 // crashes. Be careful not to assume that the variable itself will have the 56 // crashes. Be careful not to assume that the variable itself will have the
57 // expected value when displayed by the optimizer in an optimized build. 57 // expected value when displayed by the optimizer in an optimized build.
58 // Look at a memory dump of the stack. 58 // Look at a memory dump of the stack.
59 const void* program_counter = pending_task.posted_from.program_counter(); 59 const void* program_counter = pending_task.posted_from.program_counter();
60 debug::Alias(&program_counter); 60 debug::Alias(&program_counter);
61 61
62 pending_task.task.Run(); 62 pending_task.task.Run();
63 63
64 stopwatch.Stop();
64 tracked_objects::ThreadData::TallyRunOnNamedThreadIfTracking( 65 tracked_objects::ThreadData::TallyRunOnNamedThreadIfTracking(
65 pending_task, start_time, tracked_objects::ThreadData::NowForEndOfRun()); 66 pending_task, stopwatch);
66 } 67 }
67 68
68 uint64 TaskAnnotator::GetTaskTraceID(const PendingTask& task) const { 69 uint64 TaskAnnotator::GetTaskTraceID(const PendingTask& task) const {
69 return (static_cast<uint64>(task.sequence_num) << 32) | 70 return (static_cast<uint64>(task.sequence_num) << 32) |
70 ((static_cast<uint64>(reinterpret_cast<intptr_t>(this)) << 32) >> 32); 71 ((static_cast<uint64>(reinterpret_cast<intptr_t>(this)) << 32) >> 32);
71 } 72 }
72 73
73 } // namespace debug 74 } // namespace debug
74 } // namespace base 75 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | base/profiler/scoped_profile.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698