Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 445413002: Revert of Listen for key events in SetupXI2ForXWindow() (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
CC:
chromium-reviews, tdresser+watch_chromium.org, flackr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Listen for key events in SetupXI2ForXWindow() (https://codereview.chromium.org/404423002/) Reason for revert: The patch regressed editing behavior: crbug.com/401450 TBR=kpschoedel NOTRY=true Original issue's description: > Listen for key events in SetupXI2ForXWindow() > > BUG=368750 > R=sadrul > TEST=on device and desktop > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287772 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M chrome/browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2.cc View 3 chunks +3 lines, -12 lines 0 comments Download
M ui/events/x/touch_factory_x11.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lushnikov
Created Revert of Listen for key events in SetupXI2ForXWindow()
6 years, 4 months ago (2014-08-07 11:51:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/445413002/1
6 years, 4 months ago (2014-08-07 11:52:22 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 11:52:23 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-07 11:52:23 UTC) #4
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-07 11:55:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/445413002/1
6 years, 4 months ago (2014-08-07 11:55:59 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 11:57:10 UTC) #7
Message was sent while issue was closed.
Change committed as 288039

Powered by Google App Engine
This is Rietveld 408576698