[android_webview] Factor AwWebContentsObserver out of AwContentsClient.

android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java
index 9eb93b9423c3765fbc3802f0da7387018caa7ef9..c45c306f1e647ddbb4d15819c9ffc2bd1390ac65 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java
@@ -8,6 +8,7 @@ import android.test.suitebuilder.annotation.SmallTest;
 import android.webkit.ValueCallback;
 
 import org.chromium.android_webview.AwContents;
+import org.chromium.android_webview.test.TestAwContentsClient.DoUpdateVisitedHistoryHelper;
 import org.chromium.base.test.util.Feature;
 import org.chromium.content.browser.test.util.CallbackHelper;
 import org.chromium.net.test.util.TestWebServer;
@@ -16,7 +17,7 @@ import org.chromium.net.test.util.TestWebServer;
  * Tests for AwContentsClient.getVisitedHistory and AwContents.doUpdateVisitedHistory callbacks.
  */
 public class AwContentsClientVisitedHistoryTest extends AwTestBase {
-    public static class GetVisitedHistoryHelper extends CallbackHelper {
+    private static class GetVisitedHistoryHelper extends CallbackHelper {
         private ValueCallback<String[]> mCallback;
         private boolean mSaveCallback = false;
 
@@ -37,55 +38,24 @@ public class AwContentsClientVisitedHistoryTest extends AwTestBase {
         }
     }
 
-    public static class DoUpdateVisitedHistoryHelper extends CallbackHelper {
-        String mUrl;
-        boolean mIsReload;
-
-        public String getUrl() {
-            assert getCallCount() > 0;
-            return mUrl;
-        }
-
-        public boolean getIsReload() {
-            assert getCallCount() > 0;
-            return mIsReload;
-        }
-
-        public void notifyCalled(String url, boolean isReload) {
-            mUrl = url;
-            mIsReload = isReload;
-            notifyCalled();
-        }
-    }
-
     private static class TestAwContentsClient

[boliu, 2014/08/07 16:01:29]

Can we name this VisitedHistoryTestAwContentsClient to avoid confusion?

[mkosiba (inactive), 2014/08/08 10:58:44]

Done.

             extends org.chromium.android_webview.test.TestAwContentsClient {
 
         private GetVisitedHistoryHelper mGetVisitedHistoryHelper;
-        private DoUpdateVisitedHistoryHelper mDoUpdateVisitedHistoryHelper;
 
         public TestAwContentsClient() {
             mGetVisitedHistoryHelper = new GetVisitedHistoryHelper();
-            mDoUpdateVisitedHistoryHelper = new DoUpdateVisitedHistoryHelper();
         }
 
         public GetVisitedHistoryHelper getGetVisitedHistoryHelper() {
             return mGetVisitedHistoryHelper;
         }
 
-        public DoUpdateVisitedHistoryHelper getDoUpdateVisitedHistoryHelper() {
-            return mDoUpdateVisitedHistoryHelper;
-        }
-
         @Override
         public void getVisitedHistory(ValueCallback<String[]> callback) {
             getGetVisitedHistoryHelper().notifyCalled(callback);
         }
 
-        @Override
-        public void doUpdateVisitedHistory(String url, boolean isReload) {
-            getDoUpdateVisitedHistoryHelper().notifyCalled(url, isReload);
-        }
     }
 
     private TestAwContentsClient mContentsClient = new TestAwContentsClient();