Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 445393004: GN: Remove Value::RecursivelySetOrigin. (Closed)

Created:
6 years, 4 months ago by jbroman
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

GN: Remove Value::RecursivelySetOrigin. This method has been unused for about four months: https://codereview.chromium.org/223783005/ It is probably worthwhile to remove it, since it's dead and untested. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M tools/gn/value.h View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/gn/value.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jbroman
Looks like this has been unused for a while; any reason to keep it around?
6 years, 4 months ago (2014-08-08 17:54:42 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-08-11 16:37:51 UTC) #2
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 4 months ago (2014-08-11 16:54:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/445393004/1
6 years, 4 months ago (2014-08-11 16:56:10 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 17:51:13 UTC) #5
Message was sent while issue was closed.
Change committed as 288744

Powered by Google App Engine
This is Rietveld 408576698