Issue 445363009: Fix out-of-bounds exception in SetComposingRegion().

Issue 445363009: Fix out-of-bounds exception in SetComposingRegion(). (Closed)

Created:
6 years, 4 months ago by bcwhite

Modified:
6 years, 4 months ago

Reviewers:
jdduke (slow)

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix out-of-bounds exception in SetComposingRegion(). BUG=401536 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288198

Patch Set 1 #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java	View		1 chunk	+15 lines, -0 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jdduke (slow)

lgtm https://codereview.chromium.org/445363009/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/445363009/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#newcode467 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:467: setComposingRegion(mConnection, 9, 0); Nice, I assume this fails ...

6 years, 4 months ago (2014-08-07 20:07:31 UTC) #2

bcwhite

https://codereview.chromium.org/445363009/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/445363009/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#newcode467 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:467: setComposingRegion(mConnection, 9, 0); On 2014/08/07 20:07:31, jdduke wrote: > ...

6 years, 4 months ago (2014-08-07 20:10:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/445363009/1

6 years, 4 months ago (2014-08-07 20:13:57 UTC) #5

Message was sent while issue was closed.

Change committed as 288198

Expand Messages | Collapse Messages