Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 445363007: Assert allocation so we can catch it sooner. (Closed)

Created:
6 years, 4 months ago by hal.canary
Modified:
6 years, 4 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Assert allocation so we can catch it sooner. TBR= Committed: https://skia.googlesource.com/skia/+/b99c4a7bf2ff8d34b6adc053071a8bafdc868c73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/pdf/SkPDFImage.cpp View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hal.canary
PTAL - small assertion
6 years, 4 months ago (2014-08-07 18:04:33 UTC) #1
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-07 18:04:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/445363007/1
6 years, 4 months ago (2014-08-07 18:06:04 UTC) #3
commit-bot: I haz the power
Change committed as b99c4a7bf2ff8d34b6adc053071a8bafdc868c73
6 years, 4 months ago (2014-08-07 18:14:02 UTC) #4
mtklein
6 years, 4 months ago (2014-08-07 18:21:51 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698