Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 445363006: MacViews: Fix vertical alignment of text rendering. (Closed)

Created:
6 years, 4 months ago by Andre
Modified:
6 years, 4 months ago
Reviewers:
bdibello, msw
CC:
chromium-reviews, mac-views-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

MacViews: Fix vertical alignment of text rendering. NSFont returns fractional values for font metrics. We were truncating the values, causing text to appear too high vertically. The fix is to apply the ceiling function instead. BUG=401345 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/gfx/platform_font_mac.mm View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Andre
msw@, PTAL.
6 years, 4 months ago (2014-08-07 17:36:01 UTC) #1
msw
LGTM; thanks!
6 years, 4 months ago (2014-08-07 19:08:18 UTC) #2
Andre
bdibello@ FYI. Should I change PlatformFontIOS as well? How is PlatformFontIOS used currently?
6 years, 4 months ago (2014-08-07 19:30:10 UTC) #3
Andre
The CQ bit was checked by andresantoso@chromium.org
6 years, 4 months ago (2014-08-08 20:45:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andresantoso@chromium.org/445363006/1
6 years, 4 months ago (2014-08-08 20:47:27 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 00:31:13 UTC) #6
Message was sent while issue was closed.
Change committed as 288479

Powered by Google App Engine
This is Rietveld 408576698