GetProfileByUser deprecated and renamed to GetProfileByUserUnsafe.

GetProfileByUser deprecated and renamed to GetProfileByUserUnsafe.

Created safe alternative which is called GetProfileByUser.
The plan is to investigate all usages of GetProfileByUserUnsafe one by one and
replace them with a safe version, if possible.
Also warning message added for cases when GetProfileByUserUnsafe returns profile
of a wrong user or signin profile. That will help us to detect suspicious calls
to GetProfileByUserUnsafe while work in progress.

BUG=361528
TBR=yoz,dcheng,agl,dewittj,skuhne,derat

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289011

[dzhioev (left Google), 2014-08-07 19:43:45]

Hi, please review.

WARNING appears only once, on the beginning of user session. I'll fix it in a
separate CL.

[Nikita (slow), 2014-08-11 12:29:24]

lgtm but please remove this warning message since it will fill users log files
with noise in production.

https://codereview.chromium.org/445353004/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/profiles/profile_helper.cc (right):

https://codereview.chromium.org/445353004/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/profiles/profile_helper.cc:253: return profile;
nit: Insert empty line before return.

https://codereview.chromium.org/445353004/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/profiles/profile_helper.cc:268: LOG(WARNING) <<
"ProfileHelper::GetProfileByUserUnsafe is called when "
I don't think it's a good idea to commit this WARNING message. As we know that
GetProfileByUser() may be called by various callers this will result in log file
spam.

[Thiemo Nagel, 2014-08-11 14:39:47]

That looks extremely good to me.  Thanks a lot Pavel!

LGTM with nits.

[Thiemo Nagel, 2014-08-11 14:39:54]

https://codereview.chromium.org/445353004/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/profiles/profile_helper.cc (right):

https://codereview.chromium.org/445353004/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/profiles/profile_helper.cc:246: if
(user->is_profile_created())
Nit: I think it would be more readable to turn the if condition around, then you
don't need to test profile for being non-NULL in line 251:

if (!user->is_profile_created())
    return NULL;

https://codereview.chromium.org/445353004/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/profiles/profile_helper.cc:268: LOG(WARNING) <<
"ProfileHelper::GetProfileByUserUnsafe is called when "
How about DLOG() instead of LOG()?

[dzhioev (left Google), 2014-08-12 14:56:28]

https://codereview.chromium.org/445353004/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/profiles/profile_helper.cc (right):

https://codereview.chromium.org/445353004/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/profiles/profile_helper.cc:246: if
(user->is_profile_created())
On 2014/08/11 14:39:54, Thiemo Nagel wrote:
> Nit: I think it would be more readable to turn the if condition around, then
you
> don't need to test profile for being non-NULL in line 251:
> 
> if (!user->is_profile_created())
>     return NULL;

Done.

https://codereview.chromium.org/445353004/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/profiles/profile_helper.cc:253: return profile;
On 2014/08/11 12:29:24, Nikita Kostylev wrote:
> nit: Insert empty line before return.

Done.

https://codereview.chromium.org/445353004/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/profiles/profile_helper.cc:268: LOG(WARNING) <<
"ProfileHelper::GetProfileByUserUnsafe is called when "
On 2014/08/11 14:39:54, Thiemo Nagel wrote:
> How about DLOG() instead of LOG()?
Now this message shoots only once on adding user into session. The CL fixing
this is pending. However this message is a strong signal that something wrong is
happening, so I want to leave it as LOG.

[dzhioev (left Google), 2014-08-12 14:57:04]

The CQ bit was checked by dzhioev@chromium.org

[commit-bot: I haz the power, 2014-08-12 14:58:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dzhioev@chromium.org/445353004/60001

[dzhioev (left Google), 2014-08-12 15:06:26]

The CQ bit was unchecked by dzhioev@chromium.org

[dzhioev (left Google), 2014-08-12 15:06:32]

The CQ bit was checked by dzhioev@chromium.org

[commit-bot: I haz the power, 2014-08-12 15:11:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dzhioev@chromium.org/445353004/60001

[commit-bot: I haz the power, 2014-08-12 17:18:30]

Change committed as 289011