Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 445333005: DevTools: Fix tainted Function.prototype methods may disable console. (Closed)

Created:
6 years, 4 months ago by aandrey
Modified:
6 years, 4 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, blink-reviews-bindings_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Fix tainted Function.prototype methods may disable console. BUG=401535 R=pfeldman, yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179839

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : fixed test #

Patch Set 4 : another test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -47 lines) Patch
M LayoutTests/inspector/console/console-tainted-globals.html View 1 2 chunks +70 lines, -10 lines 0 comments Download
M LayoutTests/inspector/console/console-tainted-globals-expected.txt View 1 chunk +7 lines, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp View 1 1 chunk +31 lines, -10 lines 0 comments Download
M Source/core/inspector/InjectedScriptExterns.js View 1 chunk +9 lines, -3 lines 0 comments Download
M Source/core/inspector/InjectedScriptHost.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptSource.js View 1 2 3 17 chunks +19 lines, -19 lines 0 comments Download
M Source/devtools/scripts/check_injected_script_source.py View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
aandrey
6 years, 4 months ago (2014-08-07 16:37:55 UTC) #1
yurys
lgtm https://codereview.chromium.org/445333005/diff/20001/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp File Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp (right): https://codereview.chromium.org/445333005/diff/20001/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp#newcode483 Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp:483: ASSERT_NOT_REACHED(); In theory InjectedScriptHost can leak into the ...
6 years, 4 months ago (2014-08-07 16:54:03 UTC) #2
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-08-07 16:57:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/445333005/40001
6 years, 4 months ago (2014-08-07 16:59:10 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-07 18:35:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 20:05:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/20371)
6 years, 4 months ago (2014-08-07 20:05:02 UTC) #7
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-08-07 20:33:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/445333005/40001
6 years, 4 months ago (2014-08-07 20:35:37 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-07 21:46:15 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 22:51:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/20395)
6 years, 4 months ago (2014-08-07 22:51:11 UTC) #12
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-08-08 07:09:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/445333005/40001
6 years, 4 months ago (2014-08-08 07:10:31 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-08 08:28:06 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 09:50:36 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/20481)
6 years, 4 months ago (2014-08-08 09:50:37 UTC) #17
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-08-08 10:23:36 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/445333005/40001
6 years, 4 months ago (2014-08-08 10:24:18 UTC) #19
aandrey
The CQ bit was unchecked by aandrey@chromium.org
6 years, 4 months ago (2014-08-08 10:30:11 UTC) #20
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-08-08 12:33:06 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/445333005/60001
6 years, 4 months ago (2014-08-08 12:34:00 UTC) #22
yurys
PS#3 - lgtm
6 years, 4 months ago (2014-08-08 12:34:36 UTC) #23
aandrey
The CQ bit was unchecked by aandrey@chromium.org
6 years, 4 months ago (2014-08-08 12:38:15 UTC) #24
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-08-08 12:40:52 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/445333005/80001
6 years, 4 months ago (2014-08-08 12:42:00 UTC) #26
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-08 14:05:34 UTC) #27
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 15:10:08 UTC) #28
Message was sent while issue was closed.
Change committed as 179839

Powered by Google App Engine
This is Rietveld 408576698