Issue 445333004: Optimize latin1-decoder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 445333004: Optimize latin1-decoder. (Closed)

Created:
6 years, 4 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 4 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Optimize latin1-decoder. Instead of checking "allowInvalid" inside the innermost loop, create two different classes. Speeds up both cases significantly. BUG= http://dartbug.com/17659 R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=39022

Patch Set 2 : Also check for negative inputs. #

Total comments: 1

Patch Set 3 : Change the test order, so the most commen error case is first. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -12 lines)			Patch
	M	sdk/lib/convert/latin1.dart	View	1 2	2 chunks	+34 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

https://codereview.chromium.org/445333004/diff/20001/sdk/lib/convert/latin1.dart File sdk/lib/convert/latin1.dart (right): https://codereview.chromium.org/445333004/diff/20001/sdk/lib/convert/latin1.dart#newcode147 sdk/lib/convert/latin1.dart:147: if (char < 0 || char > _LATIN1_MASK) { ...

6 years, 4 months ago (2014-08-08 07:29:01 UTC) #3