Issue 44533002: Remove XMLTreeViewer virtual destructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 44533002: Remove XMLTreeViewer virtual destructor (Closed)

Created:
7 years, 1 month ago by Inactive

Modified:
7 years, 1 month ago

Reviewers:
abarth-chromium

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove XMLTreeViewer virtual destructor Remove destructor for XMLTreeViewer as it was empty and marked as virtual. This avoids creating an unnecessary vtable as this class is never subclassed nor does it have any virtual function. BUG=311561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160598

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	Source/core/xml/XMLTreeViewer.h	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/44533002/1

7 years, 1 month ago (2013-10-25 16:14:08 UTC) #3

Message was sent while issue was closed.

Change committed as 160598

Expand Messages | Collapse Messages