Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 445233006: add isRect() check to AAClip, to detect if a soft-clip is really just an irect (Closed)

Created:
6 years, 4 months ago by reed1
Modified:
6 years, 4 months ago
Reviewers:
humper, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

add isRect() check to AAClip, to detect if a soft-clip is really just an irect BUG=skia: Committed: https://skia.googlesource.com/skia/+/592cb8d552556b1e922887d506d00b64bc5d0547

Patch Set 1 #

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -3 lines) Patch
M src/core/SkAAClip.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkAAClip.cpp View 1 chunk +29 lines, -0 lines 0 comments Download
M src/core/SkRasterClip.h View 1 chunk +10 lines, -2 lines 0 comments Download
M src/core/SkRasterClip.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M tests/AAClipTest.cpp View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
reed1
The CQ bit was checked by reed@google.com
6 years, 4 months ago (2014-08-07 15:31:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/445233006/20001
6 years, 4 months ago (2014-08-07 15:31:41 UTC) #2
reed1
6 years, 4 months ago (2014-08-07 15:31:56 UTC) #3
bsalomon
lgtm
6 years, 4 months ago (2014-08-07 16:11:10 UTC) #4
reed1
The CQ bit was unchecked by reed@google.com
6 years, 4 months ago (2014-08-07 16:13:15 UTC) #5
reed1
The CQ bit was checked by reed@google.com
6 years, 4 months ago (2014-08-07 16:13:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/445233006/20001
6 years, 4 months ago (2014-08-07 16:13:32 UTC) #7
commit-bot: I haz the power
Change committed as 592cb8d552556b1e922887d506d00b64bc5d0547
6 years, 4 months ago (2014-08-07 16:20:21 UTC) #8
reed1
6 years, 4 months ago (2014-08-07 18:16:44 UTC) #9
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/452533002/ by reed@google.com.

The reason for reverting is: new code asserts on some pictures.

Powered by Google App Engine
This is Rietveld 408576698