Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5097)

Unified Diff: chrome/browser/extensions/standard_management_policy_provider.cc

Issue 445233002: Allow enhanced bookmarks external component extensions to be disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/external_component_loader.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/standard_management_policy_provider.cc
diff --git a/chrome/browser/extensions/standard_management_policy_provider.cc b/chrome/browser/extensions/standard_management_policy_provider.cc
index c9b9e4f096f71b889fa133a242812979cba8789d..28a52a0893255deefffdfff5734f4aab6067f0bb 100644
--- a/chrome/browser/extensions/standard_management_policy_provider.cc
+++ b/chrome/browser/extensions/standard_management_policy_provider.cc
@@ -6,6 +6,7 @@
#include "base/prefs/pref_service.h"
#include "chrome/browser/extensions/blacklist.h"
+#include "chrome/browser/extensions/external_component_loader.h"
#include "chrome/common/pref_names.h"
#include "extensions/browser/admin_policy.h"
#include "extensions/browser/extension_prefs.h"
@@ -54,13 +55,17 @@ bool StandardManagementPolicyProvider::UserMayLoad(
bool StandardManagementPolicyProvider::UserMayModifySettings(
const Extension* extension,
base::string16* error) const {
- return admin_policy::UserMayModifySettings(extension, error);
+ return admin_policy::UserMayModifySettings(extension, error) ||
+ (extension->location() == extensions::Manifest::EXTERNAL_COMPONENT &&
+ ExternalComponentLoader::IsModifiable(extension));
}
bool StandardManagementPolicyProvider::MustRemainEnabled(
const Extension* extension,
base::string16* error) const {
- return admin_policy::MustRemainEnabled(extension, error);
+ return admin_policy::MustRemainEnabled(extension, error) ||
+ (extension->location() == extensions::Manifest::EXTERNAL_COMPONENT &&
+ ExternalComponentLoader::IsModifiable(extension));
}
} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/external_component_loader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698