Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: chrome/browser/extensions/standard_management_policy_provider.cc

Issue 445233002: Allow enhanced bookmarks external component extensions to be disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: whitelist in ExternalComponentLoader Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/external_component_loader.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/standard_management_policy_provider.h" 5 #include "chrome/browser/extensions/standard_management_policy_provider.h"
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "chrome/browser/extensions/blacklist.h" 8 #include "chrome/browser/extensions/blacklist.h"
9 #include "chrome/browser/extensions/external_component_loader.h"
9 #include "chrome/common/pref_names.h" 10 #include "chrome/common/pref_names.h"
10 #include "extensions/browser/admin_policy.h" 11 #include "extensions/browser/admin_policy.h"
11 #include "extensions/browser/extension_prefs.h" 12 #include "extensions/browser/extension_prefs.h"
12 #include "extensions/browser/pref_names.h" 13 #include "extensions/browser/pref_names.h"
13 #include "extensions/common/extension.h" 14 #include "extensions/common/extension.h"
14 15
15 namespace extensions { 16 namespace extensions {
16 17
17 StandardManagementPolicyProvider::StandardManagementPolicyProvider( 18 StandardManagementPolicyProvider::StandardManagementPolicyProvider(
18 ExtensionPrefs* prefs) 19 ExtensionPrefs* prefs)
(...skipping 28 matching lines...) Expand all
47 if (pref_service->HasPrefPath(pref_names::kAllowedTypes)) 48 if (pref_service->HasPrefPath(pref_names::kAllowedTypes))
48 allowed_types = pref_service->GetList(pref_names::kAllowedTypes); 49 allowed_types = pref_service->GetList(pref_names::kAllowedTypes);
49 50
50 return admin_policy::UserMayLoad( 51 return admin_policy::UserMayLoad(
51 blacklist, whitelist, forcelist, allowed_types, extension, error); 52 blacklist, whitelist, forcelist, allowed_types, extension, error);
52 } 53 }
53 54
54 bool StandardManagementPolicyProvider::UserMayModifySettings( 55 bool StandardManagementPolicyProvider::UserMayModifySettings(
55 const Extension* extension, 56 const Extension* extension,
56 base::string16* error) const { 57 base::string16* error) const {
57 return admin_policy::UserMayModifySettings(extension, error); 58 return admin_policy::UserMayModifySettings(extension, error) ||
59 ExternalComponentLoader::IsModifiable(extension);
58 } 60 }
59 61
60 bool StandardManagementPolicyProvider::MustRemainEnabled( 62 bool StandardManagementPolicyProvider::MustRemainEnabled(
61 const Extension* extension, 63 const Extension* extension,
62 base::string16* error) const { 64 base::string16* error) const {
63 return admin_policy::MustRemainEnabled(extension, error); 65 return admin_policy::MustRemainEnabled(extension, error) ||
66 ExternalComponentLoader::IsModifiable(extension);
64 } 67 }
asargent_no_longer_on_chrome 2014/08/12 23:27:35 nit: can you add the check for extension->location
Mike Wittman 2014/08/13 01:25:12 Done.
65 68
66 } // namespace extensions 69 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/external_component_loader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698