Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 445173002: Moving coordinate conversion methods from ash/wm to ui/wm. (Closed)

Created:
6 years, 4 months ago by mfomitchev
Modified:
6 years, 4 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, kalyank, sadrul, dcheng, ben+ash_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Moving coordinate conversion methods from ash/wm to ui/wm. Re-submit of https://codereview.chromium.org/425363002/ TBR=sky, oshima BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288449

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -80 lines) Patch
M ash/autoclick/autoclick_controller.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/display/event_transformation_handler.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/display/mouse_cursor_event_filter.cc View 6 chunks +5 lines, -5 lines 0 comments Download
M ash/display/mouse_cursor_event_filter_ozone.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ash/drag_drop/drag_drop_tracker.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/shelf/shelf_bezel_event_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_view.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/test/ash_test_base.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/coordinate_conversion.h View 1 chunk +0 lines, -10 lines 0 comments Download
M ash/wm/coordinate_conversion.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/drag_window_resizer.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ash/wm/gestures/overview_gesture_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/panels/panel_window_resizer.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/window_resizer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 3 chunks +2 lines, -2 lines 0 comments Download
A ui/wm/core/coordinate_conversion.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ui/wm/core/coordinate_conversion.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M ui/wm/wm.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mfomitchev
Identical to https://codereview.chromium.org/425363002/ except for the changes in ash/display/mouse_cursor_event_filter_ozone.cc
6 years, 4 months ago (2014-08-06 21:25:06 UTC) #1
oshima
lgtm. you can tbr sky for the rest.
6 years, 4 months ago (2014-08-06 21:55:09 UTC) #2
sky
LGTM too - in the future make the first patch be the original (synced to ...
6 years, 4 months ago (2014-08-06 22:24:36 UTC) #3
mfomitchev
The CQ bit was checked by mfomitchev@chromium.org
6 years, 4 months ago (2014-08-06 22:25:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfomitchev@chromium.org/445173002/1
6 years, 4 months ago (2014-08-06 22:28:37 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-07 01:36:00 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 01:38:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/38345) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/2261)
6 years, 4 months ago (2014-08-07 01:38:42 UTC) #8
mfomitchev
The CQ bit was checked by mfomitchev@chromium.org
6 years, 4 months ago (2014-08-08 17:57:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfomitchev@chromium.org/445173002/20001
6 years, 4 months ago (2014-08-08 17:58:41 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 22:42:17 UTC) #11
Message was sent while issue was closed.
Change committed as 288449

Powered by Google App Engine
This is Rietveld 408576698