Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 445163003: With the overlay path moving back to passing AcceleratedWidgets, move the implementation back into … (Closed)

Created:
6 years, 4 months ago by achaulk
Modified:
6 years, 4 months ago
Reviewers:
dnicoara, spang
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

With the overlay path moving back to passing AcceleratedWidgets, move the implementation back into the surface factory. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288137

Patch Set 1 #

Patch Set 2 : remove unused comment #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -66 lines) Patch
M ui/ozone/platform/dri/dri_surface.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/gbm_surface_factory.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surface_factory.cc View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surfaceless.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surfaceless.cc View 2 chunks +1 line, -25 lines 0 comments Download
M ui/ozone/platform/dri/hardware_display_controller.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/hardware_display_controller.cc View 1 2 chunks +8 lines, -5 lines 0 comments Download
M ui/ozone/platform/egltest/ozone_platform_egltest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/ozone/public/surface_factory_ozone.h View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M ui/ozone/public/surface_factory_ozone.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M ui/ozone/public/surface_ozone_egl.h View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
achaulk
6 years, 4 months ago (2014-08-06 21:39:28 UTC) #1
dnicoara
lgtm with nits https://codereview.chromium.org/445163003/diff/20001/ui/ozone/platform/dri/gbm_surface_factory.cc File ui/ozone/platform/dri/gbm_surface_factory.cc (right): https://codereview.chromium.org/445163003/diff/20001/ui/ozone/platform/dri/gbm_surface_factory.cc#newcode16 ui/ozone/platform/dri/gbm_surface_factory.cc:16: #include "ui/ozone/public/overlay_candidates_ozone.h" Is this needed? https://codereview.chromium.org/445163003/diff/20001/ui/ozone/platform/dri/gbm_surface_factory.cc#newcode128 ...
6 years, 4 months ago (2014-08-07 14:26:04 UTC) #2
achaulk
https://codereview.chromium.org/445163003/diff/20001/ui/ozone/platform/dri/gbm_surface_factory.cc File ui/ozone/platform/dri/gbm_surface_factory.cc (right): https://codereview.chromium.org/445163003/diff/20001/ui/ozone/platform/dri/gbm_surface_factory.cc#newcode16 ui/ozone/platform/dri/gbm_surface_factory.cc:16: #include "ui/ozone/public/overlay_candidates_ozone.h" On 2014/08/07 14:26:04, dnicoara wrote: > Is ...
6 years, 4 months ago (2014-08-07 14:26:49 UTC) #3
achaulk
The CQ bit was checked by achaulk@chromium.org
6 years, 4 months ago (2014-08-07 15:12:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achaulk@chromium.org/445163003/40001
6 years, 4 months ago (2014-08-07 15:13:09 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-07 16:43:46 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 16:49:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/2629)
6 years, 4 months ago (2014-08-07 16:49:02 UTC) #8
spang
lgtm
6 years, 4 months ago (2014-08-07 20:16:07 UTC) #9
spang
The CQ bit was checked by spang@chromium.org
6 years, 4 months ago (2014-08-07 20:16:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achaulk@chromium.org/445163003/40001
6 years, 4 months ago (2014-08-07 20:26:48 UTC) #11
commit-bot: I haz the power
Change committed as 288137
6 years, 4 months ago (2014-08-07 20:41:25 UTC) #12
stevenjb
On 2014/08/07 20:41:25, I haz the power (commit-bot) wrote: > Change committed as 288137 This ...
6 years, 4 months ago (2014-08-07 21:30:17 UTC) #13
stevenjb
6 years, 4 months ago (2014-08-07 21:35:53 UTC) #14
Message was sent while issue was closed. 
On 2014/08/07 21:30:17, stevenjb wrote:
> On 2014/08/07 20:41:25, I haz the power (commit-bot) wrote:
> > Change committed as 288137
> 
> This is causing a chromeos buildbot failure:
>
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%2520ChromiumOS....

Reverted:
https://codereview.chromium.org/447073004/

Powered by Google App Engine
This is Rietveld 408576698