Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 445143002: Remove Android FontConfigInterface (Closed)

Created:
6 years, 4 months ago by Tom Hudson
Modified:
6 years, 4 months ago
Reviewers:
bungeman-skia, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Delete the old font management implementation based on SkFontConfigInterface, now that SkFontMgr_Android is live. BUG=chromium:400801 R=djsollen@google.com,bungeman@google.com Committed: https://skia.googlesource.com/skia/+/c773390eefe70d13faab147a70bd9319b9ac3afb

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Total comments: 1

Patch Set 3 : Ben's review #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -607 lines) Patch
M gyp/ports.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M include/ports/SkTypeface_android.h View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D src/ports/SkFontConfigInterface_android.cpp View 1 1 chunk +0 lines, -586 lines 0 comments Download
M src/ports/SkFontMgr_android.cpp View 1 2 3 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
tomhudson
Once Ben's fix lands, this should be clean.
6 years, 4 months ago (2014-08-06 20:09:36 UTC) #1
bungeman-skia
https://codereview.chromium.org/445143002/diff/1/src/ports/SkFontConfigInterface_android.cpp File src/ports/SkFontConfigInterface_android.cpp (left): https://codereview.chromium.org/445143002/diff/1/src/ports/SkFontConfigInterface_android.cpp#oldcode576 src/ports/SkFontConfigInterface_android.cpp:576: bool SkGetFallbackFamilyNameForChar(SkUnichar uni, const char* lang, SkString* name) { ...
6 years, 4 months ago (2014-08-06 20:29:43 UTC) #2
djsollen
https://codereview.chromium.org/445143002/diff/1/src/ports/SkFontConfigInterface_android.cpp File src/ports/SkFontConfigInterface_android.cpp (left): https://codereview.chromium.org/445143002/diff/1/src/ports/SkFontConfigInterface_android.cpp#oldcode576 src/ports/SkFontConfigInterface_android.cpp:576: bool SkGetFallbackFamilyNameForChar(SkUnichar uni, const char* lang, SkString* name) { ...
6 years, 4 months ago (2014-08-07 14:03:42 UTC) #3
Tom Hudson
Ben's change tests out locally; it is making its way through the bots, and once ...
6 years, 4 months ago (2014-08-11 20:10:15 UTC) #4
bungeman-skia
https://codereview.chromium.org/445143002/diff/20001/src/ports/SkFontConfigInterface_android.cpp File src/ports/SkFontConfigInterface_android.cpp (left): https://codereview.chromium.org/445143002/diff/20001/src/ports/SkFontConfigInterface_android.cpp#oldcode569 src/ports/SkFontConfigInterface_android.cpp:569: void SkUseTestFontConfigFile(const char* mainconf, const char* fallbackconf, This and ...
6 years, 4 months ago (2014-08-11 20:11:41 UTC) #5
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 4 months ago (2014-08-13 16:24:43 UTC) #6
bungeman-skia
lgtm
6 years, 4 months ago (2014-08-13 16:24:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tomhudson@chromium.org/445143002/60001
6 years, 4 months ago (2014-08-13 16:25:06 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 16:25:10 UTC) #9
commit-bot: I haz the power
Presubmit check for 445143002-60001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 4 months ago (2014-08-13 16:25:11 UTC) #10
djsollen
lgtm
6 years, 4 months ago (2014-08-13 17:30:48 UTC) #11
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 4 months ago (2014-08-13 17:31:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tomhudson@chromium.org/445143002/60001
6 years, 4 months ago (2014-08-13 17:32:14 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 17:41:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (60001) as c773390eefe70d13faab147a70bd9319b9ac3afb

Powered by Google App Engine
This is Rietveld 408576698