Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 445093002: Disable failing test (Closed)

Created:
6 years, 4 months ago by Albert Bodenhamer
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable failing test BUG=401169 TBR=dfalcantara NOTRY=TRUE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287818

Patch Set 1 #

Patch Set 2 : Disable the test in a java way #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Roger Tawa OOO till Jul 10th
lgtm
6 years, 4 months ago (2014-08-06 19:03:57 UTC) #1
Albert Bodenhamer
The CQ bit was checked by abodenha@chromium.org
6 years, 4 months ago (2014-08-06 19:04:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/445093002/20001
6 years, 4 months ago (2014-08-06 19:05:24 UTC) #3
commit-bot: I haz the power
Change committed as 287818
6 years, 4 months ago (2014-08-06 19:07:06 UTC) #4
Albert Bodenhamer
6 years, 4 months ago (2014-08-06 19:16:46 UTC) #5
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/447873002/ by abodenha@chromium.org.

The reason for reverting is: Disabled test incorrectly..

Powered by Google App Engine
This is Rietveld 408576698