Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: pkg/analysis_services/test/completion/top_level_computer_test.dart

Issue 445083003: exclude private declarations in imported classes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_services/lib/src/completion/top_level_computer.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_services/test/completion/top_level_computer_test.dart
diff --git a/pkg/analysis_services/test/completion/top_level_computer_test.dart b/pkg/analysis_services/test/completion/top_level_computer_test.dart
index 4136c94442e4b4801449c6036dc493cfb113cd78..da7e34ae679867eabe8eef16aaef20dd468ad966 100644
--- a/pkg/analysis_services/test/completion/top_level_computer_test.dart
+++ b/pkg/analysis_services/test/completion/top_level_computer_test.dart
@@ -25,18 +25,24 @@ class TopLevelComputerTest extends AbstractCompletionTest {
}
test_class_1() {
- addUnit('/testA.dart', 'var T1; class A {bool x;}');
+ addUnit('/testA.dart', 'var T1; class A {bool x;} var _T2; class _D { }');
addUnit('/testB.dart', 'class B {bool y;}');
- addTestUnit('import "/testA.dart"; class C {bool v;^}');
+ addTestUnit('import "/testA.dart"; class C {bool v;^} class _E { }');
return compute().then((_) {
assertHasResult(CompletionSuggestionKind.CLASS, 'A');
- assertHasResult(CompletionSuggestionKind.CLASS, 'B', CompletionRelevance.LOW);
+ assertHasResult(
+ CompletionSuggestionKind.CLASS,
+ 'B',
+ CompletionRelevance.LOW);
assertHasResult(CompletionSuggestionKind.CLASS, 'C');
+ assertNoResult('_D');
+ assertHasResult(CompletionSuggestionKind.CLASS, '_E');
assertHasResult(CompletionSuggestionKind.CLASS, 'Object');
assertHasResult(CompletionSuggestionKind.TOP_LEVEL_VARIABLE, 'T1');
+ assertNoResult('_T2');
assertNoResult('x');
assertNoResult('y');
assertNoResult('v');
});
}
-}
+}
« no previous file with comments | « pkg/analysis_services/lib/src/completion/top_level_computer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698