DevTools: reduce ResourceAgent dependency on PageAgent.

DevTools: reduce ResourceAgent dependency on PageAgent.

BUG=387874, 400937
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179846

[vsevik, 2014-08-08 11:40:59]

https://chromiumcodereview.appspot.com/445023005/diff/1/Source/core/inspector...
File Source/core/inspector/InspectorDebuggerAgent.cpp (right):

https://chromiumcodereview.appspot.com/445023005/diff/1/Source/core/inspector...
Source/core/inspector/InspectorDebuggerAgent.cpp:115:
InspectorDebuggerAgent::InspectorDebuggerAgent(InjectedScriptManager*
injectedScriptManager, EditedResourcesContentManager*
editedResourcesContentManager)
Please check whether we actually need this for debugger (we think v8 might have
a correct version of the content)

https://chromiumcodereview.appspot.com/445023005/diff/1/Source/core/inspector...
File Source/core/inspector/InspectorResourceAgent.cpp (right):

https://chromiumcodereview.appspot.com/445023005/diff/1/Source/core/inspector...
Source/core/inspector/InspectorResourceAgent.cpp:850: bool
InspectorResourceAgent::fetchResourceContent(Document* document, const KURL&
url, String* content, bool* base64Encoded)
This is only used in InspectorStyleSheet. It might be easier to simply move this
first if-branch there and get rid of editedResourcesContentManager  here
completely.

[eustas, 2014-08-08 14:03:07]

https://chromiumcodereview.appspot.com/445023005/diff/1/Source/core/inspector...
File Source/core/inspector/InspectorDebuggerAgent.cpp (right):

https://chromiumcodereview.appspot.com/445023005/diff/1/Source/core/inspector...
Source/core/inspector/InspectorDebuggerAgent.cpp:115:
InspectorDebuggerAgent::InspectorDebuggerAgent(InjectedScriptManager*
injectedScriptManager, EditedResourcesContentManager*
editedResourcesContentManager)
On 2014/08/08 11:40:59, vsevik wrote:
> Please check whether we actually need this for debugger (we think v8 might
have
> a correct version of the content) 

Acknowledged.

https://chromiumcodereview.appspot.com/445023005/diff/1/Source/core/inspector...
File Source/core/inspector/InspectorResourceAgent.cpp (right):

https://chromiumcodereview.appspot.com/445023005/diff/1/Source/core/inspector...
Source/core/inspector/InspectorResourceAgent.cpp:850: bool
InspectorResourceAgent::fetchResourceContent(Document* document, const KURL&
url, String* content, bool* base64Encoded)
On 2014/08/08 11:40:59, vsevik wrote:
> This is only used in InspectorStyleSheet. It might be easier to simply move
this
> first if-branch there and get rid of editedResourcesContentManager  here
> completely.

Done.

[vsevik, 2014-08-08 14:16:44]

lgtm

[commit-bot: I haz the power, 2014-08-08 14:17:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eustas@chromium.org/445023005/20001

[commit-bot: I haz the power, 2014-08-08 17:18:50]

Change committed as 179846