Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Unified Diff: runtime/bin/vmservice/client/HACKING.txt

Issue 445023003: Move service library test into observatory package. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/vmservice/client/pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/client/HACKING.txt
===================================================================
--- runtime/bin/vmservice/client/HACKING.txt (revision 38757)
+++ runtime/bin/vmservice/client/HACKING.txt (working copy)
@@ -33,5 +33,7 @@
In a non-Dart enabled browser navigate to localhost:8181 and ensure
that your feature works after being compiled to JavaScript.
-8. Commit your change
+8. Ensure the vm, standalone, and observatory unit tests still pass:
+python tools/test.py --mode=debug --arch=ia32 --compiler=none --runtime=vm vm/cc standalone/vmservice pkg/observatory
+9. Commit your change
« no previous file with comments | « no previous file | runtime/bin/vmservice/client/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698